Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Webview not reactive on iOS after installation of the plugin from version 4.1.0 #84

Closed
lhalleux opened this issue Feb 1, 2024 · 2 comments · Fixed by #87
Closed
Labels
bug/fix Something isn't working platform: ios iOS platform

Comments

@lhalleux
Copy link

lhalleux commented Feb 1, 2024

Plugin version:

All versions from 4.1.0 :

  • 4.1.0
  • 4.2.0
  • 4.2.1
  • 4.22

Platform(s):

  • iOS only
  • iOS 17.0.3 - Iphone 14 physical
  • iOS 17.0.0 - Iphone 15 Pro Max simulator
  • iOS 16.2 - Iphone 12 mini simulator

Current behavior:

When we use a version from 4.1.0, the webkit view is not reactive, all actions aren't intercepted.

Expected behavior:

The webkit is reactive as it need to be

Steps to reproduce:
Install a version of the privacy capacitor-community/privacy-screen from 4.1.0.
Build the application and run it on a physical device or simulated one.
Now you cannot be able to interact with the webview.

Related code:

After some debuggin, it seems to be the code that breaks the reactivity of the webview kit :

DispatchQueue.main.async {
            self.bridge?.webView?.disableScreenshots()
        }

Other information:
None, do not hesitate to contact me if you need any specific informations.

Capacitor doctor:

Latest Dependencies:

  @capacitor/cli: unknown
  @capacitor/core: unknown
  @capacitor/android: unknown
  @capacitor/ios: unknown

Installed Dependencies:

  @capacitor/cli: 5.6.0
  @capacitor/core: 5.6.0
  @capacitor/android: 5.6.0
  @capacitor/ios: 5.6.0

[info] Using Gemfile: RubyGems bundle installed
[success] iOS looking great! 👌
[success] Android looking great! 👌
@robingenz robingenz added bug/fix Something isn't working platform: ios iOS platform and removed needs: triage labels Feb 1, 2024
@robingenz
Copy link
Member

Unfortunately there are several problems with the screenshot feature. I plan to revert it (see #76 (comment)) with the next major release (which should be published this month).

@tafelnl
Copy link
Member

tafelnl commented Mar 6, 2024

@robingenz With this PR (#87) you might want to reconsider that decision :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug/fix Something isn't working platform: ios iOS platform
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants