Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HandoffDiscoveryConfiguration option when discovering readers #421

Open
1 of 5 tasks
markhermano opened this issue Jan 16, 2025 · 2 comments
Open
1 of 5 tasks
Labels
enhancement New feature or request

Comments

@markhermano
Copy link

Is your feature request related to a problem? Please describe.
We have a multi tenant android app that is already publish in Google Play. Now we also want the same app to run inside the S700 reader and since the app runs within the device it needs to be discovered with the HandoffDiscoveryConfiguraton(). See official docs here from stripe.

Describe the solution you'd like
It can any of these but I prefer the second:

  • Add a new connect type TerminalConnectType.HandoffDiscovery and implement changes within the Terminal.getInstance().discoverReaders() method
  • Create a new API StripeTerminal.handoffDiscovery() that calls fun handoffDiscovery() that reuses the Terminal.getInstance().discoverReaders() but without the connect type and location ID checks and connects directly to the first discovered reader

Describe alternatives you've considered
Wasn't able to achieve this with the current implementation

Additional context
N/A

Usage Product
N/A

Product Name:
Product URL :
Using Function:

  • Payment Sheet / Payment Flow
  • Apple Pay
  • Google Pay
  • Identity (@capacitor-community/stripe-identity)
  • Terminal(@capacitor-community/stripe-terminal)
@rdlabo rdlabo added the enhancement New feature or request label Jan 22, 2025
@rdlabo
Copy link
Member

rdlabo commented Jan 22, 2025

Thanks for issue.

Since Stripe Terminal does not allow multiple simultaneous connections, it is not desirable to create a new handoffDiscovery method, and we think to add type: hand-off should be implemented in discoverReaders.

I'm going to be busy for a while and it will be a few months before I can do this implementation, but is it possible to create a pull request? I will do my best to make time for reviews.

@markhermano
Copy link
Author

Thanks for issue.

Since Stripe Terminal does not allow multiple simultaneous connections, it is not desirable to create a new handoffDiscovery method, and we think to add type: hand-off should be implemented in discoverReaders.

I'm going to be busy for a while and it will be a few months before I can do this implementation, but is it possible to create a pull request? I will do my best to make time for reviews.

Thanks for the response and insights. I'll try to work on a pull request for this based on your desired implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants