You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, especially on web, the list of available voices can change while the page is open. Uniquely identifying a specific voice (rather than the current system) avoids the risk of playing the wrong voice due to voices getting added, etc, while the page is open.
Additionally, at least on Android, voices are unordered - so this plugin needs to order the voices in a repeatable manner such that they can be located. I'm not actually sure if voices can change while the app is open, however either way, voiceURI would be less complicated.
Ideal Solution: voice property takes a string representing the voiceURI of the voice (or a separate option for voiceURI)
The biggest problem here is that, in order to maintain backwards compatibility, such changes would increase the codebase size overall, which may not be ideal.
The text was updated successfully, but these errors were encountered:
ecc521
changed the title
voice property should utilize voiceURI instead of an array index
voice property should utilize voiceURI instead of an index
Mar 8, 2023
Also, related to #90
On Android, since the entire list of voices must be retrieved in order to find the index, it adds ~50ms overhead on my test device (OnePlus 7T, Android 12) to calls where the voice property is used. Not a major issue (especially since it's async and I believe on a different thread) but also would be a good thing to address.
We could theoretically cache the list, but I'm not seeing anything guaranteeing that the list doesn't change, so caching seems unwise as compared to using unique identifiers.
Currently, especially on web, the list of available voices can change while the page is open. Uniquely identifying a specific voice (rather than the current system) avoids the risk of playing the wrong voice due to voices getting added, etc, while the page is open.
Additionally, at least on Android, voices are unordered - so this plugin needs to order the voices in a repeatable manner such that they can be located. I'm not actually sure if voices can change while the app is open, however either way, voiceURI would be less complicated.
Ideal Solution: voice property takes a string representing the voiceURI of the voice (or a separate option for voiceURI)
The text was updated successfully, but these errors were encountered: