Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an API GET to read received SMS #16

Closed
olaxe opened this issue Nov 24, 2023 · 6 comments · Fixed by #76
Closed

Adding an API GET to read received SMS #16

olaxe opened this issue Nov 24, 2023 · 6 comments · Fixed by #76
Assignees
Labels
enhancement New feature or request

Comments

@olaxe
Copy link

olaxe commented Nov 24, 2023

Hello,

Thanks for your nice project. Do you think you can add an option to read received SMS? It is useful when someone answers to the automated SMS or to ask a question and retrieve automatically the answer.

@capcom6 capcom6 added the enhancement New feature or request label Nov 24, 2023
@capcom6
Copy link
Owner

capcom6 commented Nov 24, 2023

Hello,

Right now, this app is all about sending SMS. Receiving wasn't in the original plan, but I'll give it some thought.

Thank you for your suggestion.

@olaxe
Copy link
Author

olaxe commented Nov 25, 2023

many thanks for your consideration.

@hsul4n
Copy link

hsul4n commented Nov 27, 2023

Will be very nice feature

@olaxe
Copy link
Author

olaxe commented Feb 1, 2024

I found this app in the meantime: https://github.com/bogkonstantin/android_income_sms_gateway_webhook
It's fulfill my needs. I run both to have the way in and out.

@rayenking
Copy link

Yea waiting for this feature :"

@capcom6 capcom6 self-assigned this Jun 5, 2024
@capcom6 capcom6 linked a pull request Jun 18, 2024 that will close this issue
@capcom6
Copy link
Owner

capcom6 commented Jun 19, 2024

Good news, everyone!

I'm delighted to announce that the application now includes the capability to send webhooks when new SMS messages are received. This new feature is available for you to test from v1.15.0. The webhook functionality has been integrated into all operational modes: Local, Cloud, and Private.

Now, you might be wondering why I didn't just add a GET endpoint. There are a couple of solid reasons for this decision:

  1. Security is a top priority, and a GET endpoint could be accessed at any time, potentially exposing sensitive information. On the other hand, webhooks are pushed securely to your own server. Moreover, in Cloud mode, a GET endpoint would necessitate transferring all messages from your device to the Cloud server, raising significant privacy concerns.
  2. Efficiency is key in event-driven systems, such as SMS reception. Constantly polling a GET endpoint for new messages is resource-intensive, leading to unnecessary server load and increased battery consumption on the device. Webhooks, however, are event-driven and are triggered only when there is an actual new message, optimizing both server and device resources.

An example configuration for the webhook setup can be found at https://sms.capcom.me/getting-started/webhooks/. Rest assured, I'm working on crafting more comprehensive documentation to guide you through the process.

Thank you for your continued support, and I'm confident you'll find this new webhook feature to be a significant enhancement to your experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants