Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lists of capabilities not implemented yet #68

Open
talex5 opened this issue Mar 31, 2020 · 3 comments
Open

Lists of capabilities not implemented yet #68

talex5 opened this issue Mar 31, 2020 · 3 comments

Comments

@talex5
Copy link
Collaborator

talex5 commented Mar 31, 2020

If you define a schema with List(Interface) then:

  1. The types are wrong: it gives e.g.
    val a_get_list : t -> [`Interface_xxx] list
    instead of
    val a_get_list : t -> [`Interface_xxx] Capability.t list
  2. The implementation generated is failwith "not implemented (type iface)".

As a workaround, you can use a list of structs containing interfaces instead.

@avsm
Copy link
Collaborator

avsm commented Mar 31, 2020

Thanks; just for the record, I ran into this while implementing https://github.com/avsm/ocluster/blob/4cfd39f91a0349d02851c0f0cac8e338bc17715b/api/cluster.capnp#L27

@joprice
Copy link

joprice commented Aug 22, 2021

Is -> stream also unimplemented? I get an error like the following when I try it:

12 |   module Stream_9710718097904890872 : Stream.S with
                                           ^^^^^^^^
Error: Unbound module type Stream.S

@joprice
Copy link

joprice commented Aug 22, 2021

The docs mentioned handling this is a client side responsibility, so maybe this is actually a codegen bug.

Currently, flow control is only implemented in the C++ library. RPC implementations in other languages will treat -> stream the same as -> () until they add explicit support for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants