Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect specweights mode for prep worker #1611

Closed
PhilPhysics opened this issue Nov 25, 2024 · 1 comment · Fixed by #1613
Closed

Incorrect specweights mode for prep worker #1611

PhilPhysics opened this issue Nov 25, 2024 · 1 comment · Fixed by #1613

Comments

@PhilPhysics
Copy link

The specweights command within the prep worker has a mode called "uniform" that it calls from the initweights function of CASA. However the caracal pipeline uses the wtmode "weight" instead of wtmode "ones" for uniform. See below:

if pipeline.enable_task(config, "specweights"):
                specwts = config['specweights']["mode"]
                if specwts == "uniform":
                    step = 'init_ws-ms{:d}'.format(i)
                    recipe.add('cab/casa_script', step,
                                {
                                    "vis": msname,
                                    "script": "vis = os.path.join(os.environ['MSDIR'], '{:s}')\n"
                                    "initweights(vis=vis, wtmode='weight', dowtsp=True)".format(msname),
                                },
                                input=pipeline.input,
                                output=pipeline.output,
                                label='{0:s}:: Adding Spectral weights using MeerKAT noise specs ms={1:s}'.format(step, msname))
@Athanaseus
Copy link
Collaborator

Athanaseus commented Nov 25, 2024

Hi @PhilPhysics thank you for reporting this.

Next time, please consider contributing if you think you have a solution that works, and we'll be happy to review it.
I have pushed a fix here, #1613.

Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants