From bb51abff11539dd9331cb378b6bf29d72e382259 Mon Sep 17 00:00:00 2001 From: vbhosle Date: Fri, 30 Apr 2021 09:25:41 +0530 Subject: [PATCH] Fix #218 Arrays and Strings: One away when string are same --- Java/Ch 01. Arrays and Strings/Q1_05_One_Away/QuestionA.java | 2 +- Java/Ch 01. Arrays and Strings/Q1_05_One_Away/QuestionB.java | 2 +- Java/Ch 01. Arrays and Strings/Q1_05_One_Away/Tester.java | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/Java/Ch 01. Arrays and Strings/Q1_05_One_Away/QuestionA.java b/Java/Ch 01. Arrays and Strings/Q1_05_One_Away/QuestionA.java index 3c59b6a17..24f0c62c4 100644 --- a/Java/Ch 01. Arrays and Strings/Q1_05_One_Away/QuestionA.java +++ b/Java/Ch 01. Arrays and Strings/Q1_05_One_Away/QuestionA.java @@ -13,7 +13,7 @@ public static boolean oneEditReplace(String s1, String s2) { foundDifference = true; } } - return true; + return foundDifference; } /* Check if you can insert a character into s1 to make s2. */ diff --git a/Java/Ch 01. Arrays and Strings/Q1_05_One_Away/QuestionB.java b/Java/Ch 01. Arrays and Strings/Q1_05_One_Away/QuestionB.java index 5b2b5f723..4f49e89e9 100644 --- a/Java/Ch 01. Arrays and Strings/Q1_05_One_Away/QuestionB.java +++ b/Java/Ch 01. Arrays and Strings/Q1_05_One_Away/QuestionB.java @@ -27,7 +27,7 @@ public static boolean oneEditAway(String first, String second) { } index2++; // Always move pointer for longer string } - return true; + return foundDifference || (index1 < s1.length() || index2 < s2.length()); } diff --git a/Java/Ch 01. Arrays and Strings/Q1_05_One_Away/Tester.java b/Java/Ch 01. Arrays and Strings/Q1_05_One_Away/Tester.java index 915670190..23647701c 100644 --- a/Java/Ch 01. Arrays and Strings/Q1_05_One_Away/Tester.java +++ b/Java/Ch 01. Arrays and Strings/Q1_05_One_Away/Tester.java @@ -26,7 +26,8 @@ public static void main(String[] args) { {"adfdsfadsf", "bdfdsfadsg", "false"}, {"adfdsfadsf", "affdsfads", "false"}, {"pale", "pkle", "true"}, - {"pkle", "pable", "false"}}; + {"pkle", "pable", "false"}, + {"pale", "pale", "false"}}; for (int i = 0; i < tests.length; i++) { String[] test = tests[i]; String a = test[0];