From c90b58aaaa7581e2bc4f42637be62bbe38b6466c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Carsten=20K=C3=B6nig?= <carstenkoenig92@gmail.com>
Date: Wed, 11 Sep 2024 20:13:19 +0200
Subject: [PATCH] fix #260

---
 CHANGELOG.md                          | 5 +++++
 src/components/nodes/ClusterNodes.vue | 1 +
 src/components/nodes/NodesTable.vue   | 6 ++++--
 src/locales/cn.json                   | 3 ++-
 src/locales/en.json                   | 3 ++-
 src/locales/fr.json                   | 3 ++-
 src/models/ElasticsearchNode.ts       | 2 ++
 src/types/types.ts                    | 1 +
 8 files changed, 19 insertions(+), 5 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 4c3adfc7..5c079c47 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # Changelog
 
+## 1.1.0
+
+* show node version on nodes overview, fixes [#260](https://github.com/cars10/elasticvue/issues/260)
+* update to vue `3.5`
+
 ## 1.0.11
 
 * update chinese translation, thanks @XiangtingLee, fixes [#251](https://github.com/cars10/elasticvue/pull/251)
diff --git a/src/components/nodes/ClusterNodes.vue b/src/components/nodes/ClusterNodes.vue
index e214aaad..ea32c635 100644
--- a/src/components/nodes/ClusterNodes.vue
+++ b/src/components/nodes/ClusterNodes.vue
@@ -73,6 +73,7 @@
       'ip',
       'id',
       'name',
+      'version',
       'heap.percent',
       'heap.current',
       'heap.max',
diff --git a/src/components/nodes/NodesTable.vue b/src/components/nodes/NodesTable.vue
index 84cdd14d..e317be92 100644
--- a/src/components/nodes/NodesTable.vue
+++ b/src/components/nodes/NodesTable.vue
@@ -12,12 +12,13 @@
            data-testid="nodes-table"
            :rows-per-page-options="DEFAULT_ROWS_PER_PAGE"
            :pagination="{sortBy: 'name'}">
-    <template #body="{row}">
+    <template #body="{row}: {row: ElasticsearchNode}">
       <tr>
         <td>
           <node-icons :elasticsearch-node="row" />
         </td>
         <td>{{ row.name }}</td>
+        <td>{{ row.version }}</td>
         <td>{{ row.id }}</td>
         <td>{{ row.ip }}</td>
         <td>
@@ -88,13 +89,14 @@
 
   const filter = ref('')
   const items = computed(() => {
-    const results = filterItems<EsNode>(props.nodes, filter.value, ['name', 'ip', 'id'])
+    const results = filterItems<EsNode>(props.nodes, filter.value, ['name', 'ip', 'id', 'version'])
     return results.map(r => new ElasticsearchNode(r))
   })
 
   const columns = genColumns([
     { label: t('cluster_nodes.node_properties.status'), field: '', align: 'left' },
     { label: t('cluster_nodes.node_properties.name'), field: 'name', align: 'left' },
+    { label: t('cluster_nodes.node_properties.version'), field: 'version', align: 'left' },
     { label: t('cluster_nodes.node_properties.id'), field: 'id', align: 'left' },
     { label: t('cluster_nodes.node_properties.ip'), field: 'ip', align: 'left' },
     { label: t('cluster_nodes.node_properties.master'), field: 'master', align: 'left' },
diff --git a/src/locales/cn.json b/src/locales/cn.json
index 07434c5b..a30c5b35 100644
--- a/src/locales/cn.json
+++ b/src/locales/cn.json
@@ -264,7 +264,8 @@
       "heap": "堆内存",
       "disk": "磁盘",
       "name": "名称",
-      "status": "状态"
+      "status": "状态",
+      "version": "版本"
     }
   },
   "query": {
diff --git a/src/locales/en.json b/src/locales/en.json
index 9b6a7af4..7621497c 100644
--- a/src/locales/en.json
+++ b/src/locales/en.json
@@ -264,7 +264,8 @@
       "heap": "heap",
       "disk": "disk",
       "name": "name",
-      "status": "status"
+      "status": "status",
+      "version": "version"
     }
   },
   "query": {
diff --git a/src/locales/fr.json b/src/locales/fr.json
index 736aace1..762c1c4b 100644
--- a/src/locales/fr.json
+++ b/src/locales/fr.json
@@ -264,7 +264,8 @@
       "heap": "Heap",
       "disk": "Disque",
       "name": "Nom",
-      "status": "Statut"
+      "status": "Statut",
+      "version": "Version"
     }
   },
   "query": {
diff --git a/src/models/ElasticsearchNode.ts b/src/models/ElasticsearchNode.ts
index d035a6d7..8a6b6aa7 100644
--- a/src/models/ElasticsearchNode.ts
+++ b/src/models/ElasticsearchNode.ts
@@ -2,6 +2,7 @@ import { EsNode } from '../types/types.ts'
 
 export default class ElasticsearchNode {
   name: string
+  version: string
   id: string
   ip: string
   heapPercent: number
@@ -27,6 +28,7 @@ export default class ElasticsearchNode {
 
   constructor (options: EsNode) {
     this.name = options.name
+    this.version = options.version
     this.id = options.id
     this.ip = options.ip
     this.heapPercent = parseFloatValue(options['heap.percent'])
diff --git a/src/types/types.ts b/src/types/types.ts
index 420fd481..34603f49 100644
--- a/src/types/types.ts
+++ b/src/types/types.ts
@@ -2,6 +2,7 @@ export type EsNode = {
   name: string,
   id: string,
   ip: string,
+  version: string,
   'heap.percent': string,
   'heap.current': string,
   'heap.max': string,