Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve_breaking_argument_list doesn't preserve argument list formatting #135

Closed
innocenzi opened this issue Mar 9, 2025 · 2 comments
Closed
Assignees

Comments

@innocenzi
Copy link

Before

$this->renderer = new ChoiceRenderer(multiple: false, default: $default);

After

$this->renderer = new ChoiceRenderer(
    multiple: false,
    default: $default,
);

Before

$this->sockets = stream_socket_pair(domain: STREAM_PF_UNIX, type: STREAM_SOCK_STREAM, protocol: STREAM_IPPROTO_IP);

After

$this->sockets = stream_socket_pair(
    domain: STREAM_PF_UNIX,
    type: STREAM_SOCK_STREAM,
    protocol: STREAM_IPPROTO_IP,
);

Config

php_version = "8.4.0"

[source]
paths = ["src"]
includes = ["vendor"]
excludes = []

[format]
print_width = 180
tab_width = 4
use_tabs = false
space_after_not_operator = true
null_type_hint = "question"
space_before_arrow_function_params = true
preserve_breaking_member_access_chain = true
preserve_breaking_argument_list = true
preserve_breaking_array_like = true
preserve_breaking_parameter_list = true
preserve_breaking_attribute_list = true
preserve_breaking_conditional_expression = true

[linter]
default_plugins = true
plugins = ["symfony", "php-unit"]
@azjezz
Copy link
Member

azjezz commented Mar 9, 2025

This is breaking due to always_break_named_arguments_list being set to true by default, setting it to false fixes the issue you are having.

ref: #131 (comment)

@azjezz azjezz closed this as completed Mar 9, 2025
@azjezz azjezz self-assigned this Mar 9, 2025
@innocenzi
Copy link
Author

Makes perfect sense. Thanks for pointing it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants