Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add snapshot tests for iOS 17 and audit results #155

Closed
NickEntin opened this issue Sep 28, 2023 · 1 comment · Fixed by #195
Closed

Add snapshot tests for iOS 17 and audit results #155

NickEntin opened this issue Sep 28, 2023 · 1 comment · Fixed by #195
Assignees
@NickEntin
Labels
good first issue Good for newcomers Switch Control parity Mismatch between output of framework and actual Switch Control behavior VoiceOver parity Mismatch between output of framework and actual VoiceOver behavior

Comments

@NickEntin
Copy link
Collaborator

NickEntin commented Sep 28, 2023 •
edited
Loading

  • Add an iOS 17 device to the list in SnapshotTestCase and record new reference images. Make sure to choose a simulator that's included in the virtual image for our CI jobs.
  • Update the build scripts and CI config to include an iOS 17 build
  • Audit the reference images against VoiceOver on a device running iOS 17 and file issues for any changes/regressions where the behavior doesn't match
@NickEntin NickEntin added VoiceOver parity Mismatch between output of framework and actual VoiceOver behavior Switch Control parity Mismatch between output of framework and actual Switch Control behavior labels Sep 28, 2023
@NickEntin
Copy link
Collaborator Author

#160 and #161 will make this a bit easier

@NickEntin NickEntin added the good first issue Good for newcomers label Oct 17, 2023
@NickEntin NickEntin mentioned this issue Jan 24, 2024
Open
@NickEntin NickEntin assigned NickEntin and unassigned meherkasam Jan 24, 2024
@NickEntin NickEntin mentioned this issue Jan 24, 2024
Merged
@NickEntin NickEntin linked a pull request Jan 26, 2024 that will close this issue
Add snapshot tests for iOS 17 #195
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NickEntin NickEntin

Labels
good first issue Good for newcomers Switch Control parity Mismatch between output of framework and actual Switch Control behavior VoiceOver parity Mismatch between output of framework and actual VoiceOver behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add snapshot tests for iOS 17 cashapp/AccessibilitySnapshot
2 participants
@meherkasam @NickEntin