Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for group and module regex matching #49

Open
PaulWoitaschek opened this issue Aug 17, 2021 · 2 comments
Open

Allow for group and module regex matching #49

PaulWoitaschek opened this issue Aug 17, 2021 · 2 comments
Labels
enhancement New feature or request PR welcome

Comments

@PaulWoitaschek
Copy link

Due to weirdnesses with the maven publish plugin and same module names within nested gradle middle-modules, for our internal library the group name often times has a suffix:

I.e with a module structure like this:

featureA:presentation
featureA:data
featureB:presentation
featureB:data

We publish artifacts like:

my.company.library.featureA:presentation
my.company.library.featureA:data
my.company.library.featureB:presentation
my.company.library.featureB:data

It would be great if licensee allowed a regex matching so we can specify sth like:

ignoreDependenciesByRegex(my.company.*)

This could work similar to gradles exclusiveContent matching:

dependencyResolutionManagement {

  repositories {

    exclusiveContent {
      forRepository {
        maven {
          url 'https://maven.google.com'
        }
      }
      filter {
        includeGroupByRegex("androidx.*")
        includeGroupByRegex("com.android.tools.build.*")
        includeGroupByRegex("com.android.*")
        includeGroup("com.google.firebase")
@JakeWharton
Copy link
Collaborator

Makes sense to me!

@consp1racy
Copy link
Contributor

I believe

ignoreDependenciesByRegex("my.company.*")

should actually read

ignoreDependenciesByRegex("my\\.company(\\..*)?")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR welcome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants