Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for installing StagehandTesting via Swift Package Manager #2

Open
NickEntin opened this issue Jan 17, 2020 · 5 comments
Open

Add support for installing StagehandTesting via Swift Package Manager #2

NickEntin opened this issue Jan 17, 2020 · 5 comments
Assignees
@NickEntin
Labels
enhancement Request for a new feature or improvement to an existing feature

Comments

@NickEntin
Copy link
Collaborator

No description provided.

@NickEntin NickEntin added the enhancement Request for a new feature or improvement to an existing feature label Jan 17, 2020
@NickEntin
Copy link
Collaborator Author

Supporting SPM for StagehandTesting is blocked by uber/ios-snapshot-test-case#91, since StagehandTesting has a dependency on iOSSnapshotTestCase. We could potentially add support for only Stagehand now, and follow up with StagehandTesting once that dependency is available.

@NickEntin NickEntin mentioned this issue Feb 14, 2020
Closed
@NickEntin
Copy link
Collaborator Author

It looks like SPM will support publishing multiple libraries in the same package. One extra piece of complexity here is that StagehandTesting needs to be able to @testable import Stagehand. That is handled in Cocoapods here, but I'm not sure how it will work with SPM.

NickEntin added a commit that referenced this issue Feb 14, 2020
@NickEntin
Add support for installing Stagehand via SPM
15615cf 
This resolves part of #2, since it only supports Stagehand and not StagehandTesting.
NickEntin added a commit that referenced this issue Mar 6, 2020
@NickEntin
Add support for installing Stagehand via SPM
08b92a0 
This resolves part of #2, since it only supports Stagehand and not StagehandTesting.
NickEntin added a commit that referenced this issue Mar 6, 2020
@NickEntin
Add support for installing Stagehand via SPM (#15)
7e69236 
* Adds support for installing Stagehand via Swift Package Manager
* Adds scripts for running builds on CI
* Updates directory structure to recommended SPM structure
* Updates installation instructions in README

This resolves part of #2, since it only supports Stagehand and not StagehandTesting.
@NickEntin
Copy link
Collaborator Author

This has been partially resolved by #15, and Stagehand can now be installed via SPM. This ticket is still open to track the remaining work to make StagehandTesting work as well.

@NickEntin NickEntin changed the title Add support for installing via Swift Package Manager Add support for installing StagehandTeasting via Swift Package Manager Jul 2, 2020
@NickEntin NickEntin changed the title Add support for installing StagehandTeasting via Swift Package Manager Add support for installing StagehandTesting via Swift Package Manager Jul 2, 2020
@NickEntin
Copy link
Collaborator Author

This will be a bit easier after landing #54, since SnapshotTesting already supports SPM.

@NickEntin NickEntin self-assigned this Dec 23, 2020
@NickEntin
Copy link
Collaborator Author

I have a branch that I think should resolve this. I'm trying to test it, but my sample SPM project keeps crashing Xcode. 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NickEntin NickEntin

Labels
enhancement Request for a new feature or improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NickEntin