Dice are consumed on activation

[ZChris13]

Describe the bug

One of the recent changes to using items has caused dice to consume themselves upon use

Steps To Reproduce

obtain any RPG die, activate it to roll it
observe that it has disappeared
if you have multiple, observe that it will consume the entire stack as many as the number it rolled

Screenshots

Versions and configuration

• OS: Windows
  • OS Version: 10.0.19045.5131 (22H2)
• Game Version: 08833c3 [64-bit]
• Graphics Version: Tiles
• LAPI Version: 2
• Game Language: []
• Mods loaded: [
  Bright Nights [bn],
  Disable NPC Needs [no_npc_food],
  Simplified Nutrition [novitamins],
  No Rail Stations [No_Rail_Stations],
  Limit Fungal Growth [limit_fungal_growth],
  Teleportation [teleportation_tech],
  Craftable Gun Pack [craftgp]
  ]

Additional context

I collect dice :)

I am very sad that my stack of seven 20 sided metal dice were consumed :(

[scarf005]

cc @KheirFerrum

[KheirFerrum]

This is a known bug we inherited. I have no idea why the fuck the iuse was coded the way it was. The iuse should instead return 0 instead if the roll value. I may throw a PR together later today if no one else does. It's basically a single line change.

[ZChris13]

this is new, BRB checking which release it happened in

[ZChris13]

release 6bbf3ad (2024-10-17) does not have the bug
release 88c3a84 (2024-10-19) does have the bug

I guess you knew that it was your PR #5589 that was causing this?

[KheirFerrum]

release 6bbf3ad (2024-10-17) does not have the bug release 88c3a84 (2024-10-19) does have the bug

I guess you knew that it was your PR #5589 that was causing this?

Lol, interesting, had an inkling, but no, I did not. I came across this bug while I was refactoring #5259. Looks like fixing one bug exposed another. The issue here is that iuse action is supposed to return charges to use, this was masked by a separate bug that was causing the returned value to not be used up.

A fix will be up in a short bit.