Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suspended Users can still login #55

Open
jtsafran opened this issue Jul 29, 2020 · 2 comments
Open

Suspended Users can still login #55

jtsafran opened this issue Jul 29, 2020 · 2 comments
Labels
bug

Comments

@jtsafran
Copy link

Confirmed in both Totara 12 and Moodle 3.8. If a user's profile has the suspended flag set, the flag is ignored and the user is able to login.

The intent is probably to pair this call with core_user_get_users and check the suspended flag and never make the API call to log the user in in the first place, however, it makes sense to make sure the user is not suspended when following the login URL. There could be a scenario where the user is suspended between the time that core_user_get_users is called and then auth_userkey_request_login_url and the login URL is followed.
@dmitriim dmitriim added the bug label Jul 29, 2020
@dmitriim
Copy link
Member

Hi @jtsafran thank you for reporting this one. Please feel free to submit a patch for fixing it.

@dmitriim
Copy link
Member

There is #87 for fixing this issue. Still needs some work though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmitriim @jtsafran