From a6ac198e55b2b3402e9e0ce082ef6ffebdbd1c9d Mon Sep 17 00:00:00 2001 From: Marcus Green Date: Mon, 18 Dec 2023 17:27:46 +0000 Subject: [PATCH] WR421526:Removed MOODLE_INTERNAL_CHECKS for standards compliance Coding standards changed and these checks were cluttering the ci linting, making it hard to see "real" issues. --- classes/event/event_processed.php | 2 -- classes/output/all_participants_inprogress.php | 2 -- classes/output/assess_by_activity.php | 2 -- classes/output/assess_by_month.php | 2 -- classes/output/assess_by_month_student.php | 2 -- classes/output/inprogress_participant_summary.php | 2 -- classes/output/participant_summary.php | 2 -- classes/output/participant_trend.php | 2 -- classes/output/renderer.php | 2 -- classes/output/upcomming_quizzes.php | 2 -- classes/privacy/provider.php | 2 -- classes/quiz.php | 2 -- classes/task/data_process.php | 2 -- classes/task/history_process.php | 2 -- classes/task/quiz_tracking.php | 2 -- classes/utils.php | 2 -- db/install.php | 2 -- lib.php | 2 -- tests/external_test.php | 2 -- version.php | 2 +- 20 files changed, 1 insertion(+), 39 deletions(-) diff --git a/classes/event/event_processed.php b/classes/event/event_processed.php index da13bcd..ed3385a 100644 --- a/classes/event/event_processed.php +++ b/classes/event/event_processed.php @@ -24,8 +24,6 @@ namespace local_assessfreq\event; -defined('MOODLE_INTERNAL') || die(); - /** * Event class. * diff --git a/classes/output/all_participants_inprogress.php b/classes/output/all_participants_inprogress.php index 534cdcc..fd25677 100644 --- a/classes/output/all_participants_inprogress.php +++ b/classes/output/all_participants_inprogress.php @@ -26,8 +26,6 @@ use local_assessfreq\quiz; -defined('MOODLE_INTERNAL') || die; - /** * Renderable for all participant summary card. * diff --git a/classes/output/assess_by_activity.php b/classes/output/assess_by_activity.php index 7858574..be8bab9 100644 --- a/classes/output/assess_by_activity.php +++ b/classes/output/assess_by_activity.php @@ -26,8 +26,6 @@ use local_assessfreq\frequency; -defined('MOODLE_INTERNAL') || die; - /** * Renderable for assessments by activity card. * diff --git a/classes/output/assess_by_month.php b/classes/output/assess_by_month.php index 229cc7e..2521efa 100644 --- a/classes/output/assess_by_month.php +++ b/classes/output/assess_by_month.php @@ -26,8 +26,6 @@ use local_assessfreq\frequency; -defined('MOODLE_INTERNAL') || die; - /** * Renderable for assessments due by month card. * diff --git a/classes/output/assess_by_month_student.php b/classes/output/assess_by_month_student.php index d6e8042..0406be6 100644 --- a/classes/output/assess_by_month_student.php +++ b/classes/output/assess_by_month_student.php @@ -26,8 +26,6 @@ use local_assessfreq\frequency; -defined('MOODLE_INTERNAL') || die; - /** * Renderable for assessments due by month student card. * diff --git a/classes/output/inprogress_participant_summary.php b/classes/output/inprogress_participant_summary.php index d4ad6bb..a984de2 100644 --- a/classes/output/inprogress_participant_summary.php +++ b/classes/output/inprogress_participant_summary.php @@ -24,8 +24,6 @@ namespace local_assessfreq\output; -defined('MOODLE_INTERNAL') || die; - /** * Renderable for participant summary card. * diff --git a/classes/output/participant_summary.php b/classes/output/participant_summary.php index 65b1360..2c2fba6 100644 --- a/classes/output/participant_summary.php +++ b/classes/output/participant_summary.php @@ -26,8 +26,6 @@ use local_assessfreq\quiz; -defined('MOODLE_INTERNAL') || die; - /** * Renderable for participant summary card. * diff --git a/classes/output/participant_trend.php b/classes/output/participant_trend.php index db9e170..dafceb0 100644 --- a/classes/output/participant_trend.php +++ b/classes/output/participant_trend.php @@ -26,8 +26,6 @@ use local_assessfreq\quiz; -defined('MOODLE_INTERNAL') || die; - /** * Renderable for participant trend card. * diff --git a/classes/output/renderer.php b/classes/output/renderer.php index ead4d4c..da81c78 100644 --- a/classes/output/renderer.php +++ b/classes/output/renderer.php @@ -25,8 +25,6 @@ use local_assessfreq\quiz; -defined('MOODLE_INTERNAL') || die; - use plugin_renderer_base; use local_assessfreq\frequency; diff --git a/classes/output/upcomming_quizzes.php b/classes/output/upcomming_quizzes.php index f07da54..e1506f6 100644 --- a/classes/output/upcomming_quizzes.php +++ b/classes/output/upcomming_quizzes.php @@ -26,8 +26,6 @@ use local_assessfreq\quiz; -defined('MOODLE_INTERNAL') || die; - /** * Renderable for upcomming quizzes card. * diff --git a/classes/privacy/provider.php b/classes/privacy/provider.php index 16b44b7..5b9c33a 100644 --- a/classes/privacy/provider.php +++ b/classes/privacy/provider.php @@ -24,8 +24,6 @@ namespace local_assessfreq\privacy; -defined('MOODLE_INTERNAL') || die(); - use core_privacy\local\metadata\collection; use core_privacy\local\request\contextlist; use core_privacy\local\request\approved_contextlist; diff --git a/classes/quiz.php b/classes/quiz.php index 57405d4..7809d78 100644 --- a/classes/quiz.php +++ b/classes/quiz.php @@ -26,8 +26,6 @@ use mod_quiz\question\bank\qbank_helper; -defined('MOODLE_INTERNAL') || die(); - /** * Quiz data class. * diff --git a/classes/task/data_process.php b/classes/task/data_process.php index a698133..c91bacd 100644 --- a/classes/task/data_process.php +++ b/classes/task/data_process.php @@ -25,8 +25,6 @@ use core\task\scheduled_task; -defined('MOODLE_INTERNAL') || die(); - /** * A scheduled task to generate data used in plugin reports. * diff --git a/classes/task/history_process.php b/classes/task/history_process.php index 65a7724..e9a1908 100644 --- a/classes/task/history_process.php +++ b/classes/task/history_process.php @@ -25,8 +25,6 @@ use core\task\adhoc_task; -defined('MOODLE_INTERNAL') || die(); - /** * Adhoc task to process historical data used in plugin. * diff --git a/classes/task/quiz_tracking.php b/classes/task/quiz_tracking.php index 15e2625..f6b0ae6 100644 --- a/classes/task/quiz_tracking.php +++ b/classes/task/quiz_tracking.php @@ -25,8 +25,6 @@ use core\task\scheduled_task; -defined('MOODLE_INTERNAL') || die(); - /** * A scheduled task to track the process of quizzes in the system. * diff --git a/classes/utils.php b/classes/utils.php index d11b600..1eab69c 100644 --- a/classes/utils.php +++ b/classes/utils.php @@ -24,8 +24,6 @@ namespace local_assessfreq; -defined('MOODLE_INTERNAL') || die(); - /** * Utils class. * diff --git a/db/install.php b/db/install.php index 3e59e45..a81c96a 100644 --- a/db/install.php +++ b/db/install.php @@ -22,8 +22,6 @@ * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later */ -defined('MOODLE_INTERNAL') || die(); - /** * Generate ad-hoc task on install. */ diff --git a/lib.php b/lib.php index efd6f29..62be2cf 100644 --- a/lib.php +++ b/lib.php @@ -22,8 +22,6 @@ * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later */ -defined('MOODLE_INTERNAL') || die(); - /** * Returns the name of the user preferences as well as the details this plugin uses. diff --git a/tests/external_test.php b/tests/external_test.php index 632f53a..d05635f 100644 --- a/tests/external_test.php +++ b/tests/external_test.php @@ -24,8 +24,6 @@ namespace local_assessfreq; -defined('MOODLE_INTERNAL') || die(); - use assign; use context_module; use external_api; diff --git a/version.php b/version.php index 074d19d..a963487 100644 --- a/version.php +++ b/version.php @@ -27,7 +27,7 @@ $plugin->component = 'local_assessfreq'; $plugin->release = '2023102700'; $plugin->version = 2023102700; -$plugin->requires = 2023042400; // Requires 4.2 +$plugin->requires = 2023042400; // Requires 4.2. $plugin->supports = [402, 402]; $plugin->maturity = MATURITY_STABLE;