From 5c19516dd93827ad2cfc8fe97e7e0c5c85a84fd4 Mon Sep 17 00:00:00 2001 From: Guillermo Gomez Date: Fri, 26 Jun 2020 14:28:40 +1000 Subject: [PATCH] plagiarism_turnitin_users missing from privacy class --- classes/privacy/provider.php | 8 ++++++++ lang/en/plagiarism_turnitin.php | 3 +++ tests/privacy/provider_test.php | 8 ++++---- 3 files changed, 15 insertions(+), 4 deletions(-) diff --git a/classes/privacy/provider.php b/classes/privacy/provider.php index ccb0704c..077c3231 100644 --- a/classes/privacy/provider.php +++ b/classes/privacy/provider.php @@ -71,6 +71,14 @@ public static function _get_metadata(collection $collection) { 'privacy:metadata:plagiarism_turnitin_files' ); + $collection->add_database_table( + 'plagiarism_turnitin_users', + [ + 'userid' => 'privacy:metadata:plagiarism_turnitin_users:userid', + ], + 'privacy:metadata:plagiarism_turnitin_users' + ); + $collection->link_external_location('plagiarism_turnitin_client', [ 'email' => 'privacy:metadata:plagiarism_turnitin_client:email', 'firstname' => 'privacy:metadata:plagiarism_turnitin_client:firstname', diff --git a/lang/en/plagiarism_turnitin.php b/lang/en/plagiarism_turnitin.php index bb1182d6..74c668f0 100644 --- a/lang/en/plagiarism_turnitin.php +++ b/lang/en/plagiarism_turnitin.php @@ -273,6 +273,9 @@ $string['privacy:metadata:plagiarism_turnitin_client:submission_filename'] = 'The name of the submitted file is sent to Turntin so that it is identifiable.'; $string['privacy:metadata:plagiarism_turnitin_client:submission_content'] = 'Please be aware that the content of a file/submission is sent to Turnitin for processing.'; +$string['privacy:metadata:plagiarism_turnitin_users'] = 'Information about Plagiarism Plugin Users.'; +$string['privacy:metadata:plagiarism_turnitin_users:userid'] = 'The ID of the user who uses this plugin.'; + $string['privacy:metadata:core_files'] = 'Turnitin Assignment stores files that have been uploaded to Moodle to form a Turnitin submission.'; $string['errorcode13'] = 'This submissionid - {$a->externalid} was not found in Turnitin. Unable to retrieve similarity score and other submission data.'; diff --git a/tests/privacy/provider_test.php b/tests/privacy/provider_test.php index e5f50fe1..976acea0 100644 --- a/tests/privacy/provider_test.php +++ b/tests/privacy/provider_test.php @@ -51,7 +51,7 @@ public function test_get_metadata() { $newcollection = provider::get_metadata($collection); $itemcollection = $newcollection->get_collection(); - $this->assertCount(3, $itemcollection); + $this->assertCount(4, $itemcollection); // Verify core_files data is returned. $this->assertEquals('core_files', $itemcollection[0]->get_name()); @@ -72,9 +72,9 @@ public function test_get_metadata() { $this->assertArrayHasKey('student_read', $privacyfields); // Verify plagiarism_turnitin_client data is returned. - $this->assertEquals('plagiarism_turnitin_client', $itemcollection[2]->get_name()); + $this->assertEquals('plagiarism_turnitin_client', $itemcollection[3]->get_name()); - $privacyfields = $itemcollection[2]->get_privacy_fields(); + $privacyfields = $itemcollection[3]->get_privacy_fields(); $this->assertArrayHasKey('email', $privacyfields); $this->assertArrayHasKey('firstname', $privacyfields); $this->assertArrayHasKey('lastname', $privacyfields); @@ -82,7 +82,7 @@ public function test_get_metadata() { $this->assertArrayHasKey('submission_filename', $privacyfields); $this->assertArrayHasKey('submission_content', $privacyfields); - $this->assertEquals('privacy:metadata:plagiarism_turnitin_client', $itemcollection[2]->get_summary()); + $this->assertEquals('privacy:metadata:plagiarism_turnitin_client', $itemcollection[3]->get_summary()); } /**