Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements #27

Closed
weiglszonja opened this issue May 23, 2024 · 1 comment
Closed

Improvements #27

weiglszonja opened this issue May 23, 2024 · 1 comment

Comments

@weiglszonja
Copy link
Collaborator 

          Just a minor comment: I don't think you need to specify Green in the `FiberPhotometryResponseSeries` name. Since they are all Green. And I would store only two series `FiberPhotometryResponseSeriesSignal` and the `FiberPhotometryResponseSeriesIsobestic` both of them having the Fiber1 and Fiber2 signal. But we could change this in a follow-up PR after  mid-way meeting

Originally posted by @alessandratrapani in #24 (review)
@weiglszonja weiglszonja changed the title Change series Improvements May 23, 2024
@weiglszonja
Copy link
Collaborator Author

Also fix the unit to "n.a."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@weiglszonja