Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation]: Should we add Returns section to the docstrings of our get methods (get_metadata, etc.) #1097

Open
2 tasks done
pauladkisson opened this issue Sep 18, 2024 · 6 comments · May be fixed by #1185
Open
2 tasks done

Comments

@pauladkisson
Copy link
Member

pauladkisson commented Sep 18, 2024

See #1063

Code of Conduct

@pauladkisson
Copy link
Member Author

On the one hand, documentation = good, OTH simple 1-liners usually suffice to convey all the relevant info.

@h-mayorquin
Copy link
Collaborator

I am leaning toward yes as in most cases implementing them at the base interface should work for most cases so it is not a lot of work. Plus, is a uniform rule, everything should have arguments and returns...

@h-mayorquin
Copy link
Collaborator

@pauladkisson is your preference for yes? I think that the other team members do not have a preference so if you have this one we can just start moving slowly towards it as I don't have a strong one either.

@pauladkisson
Copy link
Member Author

Yeah, let's do it. It will be more consistent with all the other docstrings.

@h-mayorquin
Copy link
Collaborator

Maybe seeing if it can add this is a good test bed for Cline capabilities?

@pauladkisson
Copy link
Member Author

Maybe seeing if it can add this is a good test bed for Cline capabilities?

Yeah, good idea! It's a simple request/easy to validate, but requires keeping track of a lot of files, which has been a failure point for agents in my experience. Do we have a CN API key? It might be a larger job.

@pauladkisson pauladkisson linked a pull request Jan 24, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants