Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing context on errors #108

Open
mkreidenweis opened this issue Mar 7, 2018 · 0 comments
Open

Missing context on errors #108

mkreidenweis opened this issue Mar 7, 2018 · 0 comments

Comments

@mkreidenweis
Copy link

Hi, we currently experience an issue with sitespeed.io, which is using webpagetest-api to drive WPT:
sitespeedio/sitespeed.io#1928

Unfortunately the error coming from webpagetest-api gives practically no context on where the error happened.

Could you maybe add a little more context to errors returned from webpagetest-api?

From what I can see it shouldn't be hard to add e.g. pathname to the err somehow here:
https://github.com/marcelduran/webpagetest-api/blob/6bac270b59c44f1f4841231db14c16b8544e44ca/lib/webpagetest.js#L228

I'm not quite sure how the WPTAPIError is supposed to be used though and how I would integrated the new behavior into your test suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant