Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google #51

Closed
1 task done
GitMuslim opened this issue May 1, 2023 · 18 comments
Closed
1 task done

Google #51

GitMuslim opened this issue May 1, 2023 · 18 comments

Comments

@GitMuslim
Copy link
Member

GitMuslim commented May 1, 2023

Link to repository

https://github.com/mustafakhalaf-git/google

Screenshots

image

Any additional comments?

No response

Submission Guidelines

  • I have read and followed Catppuccin's submission guidelines.
@isabelroses
Copy link
Member

Hello,

Changes to be done
  1. These links are not following ctp guidelines a.MV3Tnb class name for reference
    image
  2. The "im feeling lucky" button breaks upon hover
    Example frame:
    image
  3. hover of top button adds too many background colour changes, same issue occurs on the user profile
    image
  4. I can't really notice a diffrence between the popout here and the main background
    image
  5. google has a dark mode and a light mode built in by default, is it possible to have a light mode and dark mode auto select similar to your own twitch port
  6. The advance search feature is not themed
    image
  7. send feed back also not themed
    image

Good work so far otherwise.

@isabelroses
Copy link
Member

I also just noticed when a button is :active it becomes not ctp.

@sgoudham
Copy link
Contributor

sgoudham commented May 2, 2023

Note
We are putting userstyle issues on hold while catppuccin/community#4 is being discussed.

@isabelroses
Copy link
Member

isabelroses commented May 3, 2023

Another issue:
image
image

@GitMuslim
Copy link
Member Author

GitMuslim commented May 5, 2023

@isabelroses If someone wishes to make a port for let's say Google Maps or so, would we make that they should merge it within this repo or make a new repo for it?

or better ask if I wish to theme more than just the search later on, would that be fine?

@vanillyn
Copy link

vanillyn commented May 6, 2023

image
quick note; you may want to limit it to just google.com and google.com/search...

@isabelroses
Copy link
Member

@isabelroses If someone wishes to make a port for let's say Google Maps or so, would we make that they should merge it within this repo or make a new repo for it?

I was thinking about this one myself as I realised, they come together under the name gsuite including gmail etc, so i was thinking that when its all done we could have a gsuite repo that could echo all the code from the indidual repos into one file or something. Another idea i had was to create just a single larger file with all of the themes and toggles for each individual website e.g. Gmail, Google, Google Docs.

@GitMuslim
Copy link
Member Author

@vanillyn I'm discussing possible future work

@GitMuslim
Copy link
Member Author

@isabelroses If someone wishes to make a port for let's say Google Maps or so, would we make that they should merge it within this repo or make a new repo for it?

I was thinking about this one myself as I realised, they come together under the name gsuite including gmail etc, so i was thinking that when its all done we could have a gsuite repo that could echo all the code from the indidual repos into one file or something. Another idea i had was to create just a single larger file with all of the themes and toggles for each individual website e.g. Gmail, Google, Google Docs.

Perhaps, we may see when userstyle submission is open again

@isabelroses
Copy link
Member

Just another small issue:
image
link to replicate

@GitMuslim
Copy link
Member Author

Just another small issue: image link to replicate

fixed this one, as well as the buttons (Images, Videos, News, etc..)

@sgoudham
Copy link
Contributor

Hiya 👋

I'm happy to announce that ports which are themed with Stylus (called "Userstyles") now live over at https://github.com/catppuccin/userstyles. This means that your existing work will have to be transformed into a pull request to that repository.

Please follow the documentation detailed here on how to create a userstyle.

I'll be transferring this issue to the userstyles repository as they will not be reviewed here anymore. Thank you for your patience during this process!

@sgoudham sgoudham transferred this issue from catppuccin/catppuccin Jul 20, 2023
@isabelroses
Copy link
Member

hai @GitMuslim just noticed that a new issue has arrisen:
image

@GitMuslim
Copy link
Member Author

this will need to be re-written in less first

@isabelroses
Copy link
Member

isabelroses commented Jul 24, 2023

this will need to be re-written in less first

True, if u need help you can ask me, check the contrib docs or see the template in the root of this repo.

@GitMuslim
Copy link
Member Author

GitMuslim commented Nov 17, 2023

this will need to be re-written in less first

True, if u need help you can ask me, check the contrib docs or see the template in the root of this repo.

@isabelroses here it is #325

@uncenter
Copy link
Member

Probably should close it when the PR merges... lol.

@GitMuslim
Copy link
Member Author

Probably should close it when the PR merges... lol.

This was just temporarily here until I make the less repo, no point of keeping it open anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants