Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hoppscotch.io #63

Closed
1 task done
sgoudham opened this issue Feb 4, 2023 · 17 comments
Closed
1 task done

Hoppscotch.io #63

sgoudham opened this issue Feb 4, 2023 · 17 comments

Comments

@sgoudham
Copy link
Contributor

sgoudham commented Feb 4, 2023

@justTOBBI has made a port for Hoppscotch.
It's ready for review: justTOBBI/hoppscotch

Discussed in catppuccin/catppuccin#1907

Originally posted by justTOBBI February 4, 2023

Will you make the port?

  • Yes, I'm willing to make the port

How can the requested port be themed?

via Stylus Userthemes

Has the requested port been themed already?

https://github.com/justTOBBI/hoppscotch

Any additional comments?

Have a beautiful day, my friends ☕

@sgoudham
Copy link
Contributor Author

sgoudham commented Feb 7, 2023

Hey @justTOBBI, thanks for your work here.

I have a few comments here:

  1. The cursor line highlighting seems quite harsh on Latte? I think it would be good to maybe switch the highlights from the line numbers and the text? Would be curious on how that looks.

    image

  2. IIRC, Our style guide says that the highlights on our darker themes should be getting lighter instead of darker. It looks like all on-hover highlights currently go to crust but I believe they're supposed to get lighter? Do you think the below highlights would look better when it's lighter instead of darker?

    Hovering above GraphQL
    image

    Hovering above Documentation in Support Pane
    image

Curious to know what you think!

@justTOBBI
Copy link
Member

Dear @sgoudham,
the hover effect is done by Hoppscotch and I don't think we should change how stuff works as per codeberg#2
Further on, the Documentation Bug does not appear for me, so maybe update the app or something?
I did push the cursor line change :D

@sgoudham
Copy link
Contributor Author

Ah interesting, I actually only tested this via the browser since it seems to be a stylus theme?
Is there an app for this?

@justTOBBI
Copy link
Member

Its a PWA but I use it in the Browser. I will look into the hover bug again if it is persistent to you
Does the rest of the changes appeal to you though?

@sgoudham
Copy link
Contributor Author

I didn't actually see the cursorline changes, can you confirm that you updated it?

@justTOBBI
Copy link
Member

Oops, I forgot to push the change. I'll do it when I get home :)

@justTOBBI
Copy link
Member

Okay, I just pushed the change

@sgoudham
Copy link
Contributor Author

Note
We are putting userstyle issues on hold while catppuccin/community#4 is being discussed.

@sgoudham
Copy link
Contributor Author

Hiya 👋

I'm happy to announce that ports which are themed with Stylus (called "Userstyles") now live over at https://github.com/catppuccin/userstyles. This means that your existing work will have to be transformed into a pull request to that repository.

Please follow the documentation detailed here on how to create a userstyle.

I'll be transferring this issue to the userstyles repository as they will not be reviewed here anymore. Thank you for your patience during this process!

@sgoudham sgoudham transferred this issue from catppuccin/catppuccin Jul 20, 2023
@sgoudham
Copy link
Contributor Author

Hey @justTOBBI, are you still planning on taking this forward and converting this to LESS?

@justTOBBI
Copy link
Member

Hey @justTOBBI, are you still planning on taking this forward and converting this to LESS?

I am still planning on doing that, but it could take a while so someone could also jump in and help :)

@sgoudham
Copy link
Contributor Author

Sounds good, @isabelroses might be interested then!

@isabelroses
Copy link
Member

isabelroses commented Aug 20, 2023

Sounds good, @isabelroses might be interested then!

One step ahead of you hammy, https://github.com/justTOBBI/ctp-hoppscotch/pull/1

@justTOBBI
Copy link
Member

Tf how fast did you do that?

@sgoudham
Copy link
Contributor Author

If @justTOBBI is happy with that, it'd be great to raise it as a pull request and get it merged here! @isabelroses

@justTOBBI
Copy link
Member

I will do that very shortly after I finish working on my personal project

@isabelroses
Copy link
Member

closed by #212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants