Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline completions indistinguishable from highlighted background #30

Open
doraut opened this issue Aug 2, 2024 · 3 comments
Open

Inline completions indistinguishable from highlighted background #30

doraut opened this issue Aug 2, 2024 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed linux

Comments

@doraut
Copy link

doraut commented Aug 2, 2024

I noticed that inline completions inside highlighted text are indistinguishable from the background:

This is with "Catppuccin Mocha":
Screenshot from 2024-08-02 09-29-25

For comparison, this is what it looks like with the "One Dark" Theme:
image

Versions

Catppuccin Themes: v0.2.10
Zed: v0.147.1 (Zed Preview)
OS: Linux Wayland ubuntu 22.04

@tecandrew
Copy link
Collaborator

thanks for reporting. seems like a regression. I remember accommodating for this in a previous patch. a regression, or something Linux specific.

will look into this when I get access to a Linux machine.

i forget if this is something shown by Copilot/Supermaven or Zed's Assistant Panel

@tecandrew tecandrew added bug Something isn't working linux labels Aug 3, 2024
@tecandrew
Copy link
Collaborator

coming back to this to find that my personal Linux PC doesn't play well with Zed since it doesn't have a supported Vulkan GPU. it's unbearably slow.

I'd be happy to merge any fixes on this if one has the time to debug on Linux Desktop

@tecandrew tecandrew added the help wanted Extra attention is needed label Aug 29, 2024
@ali-42
Copy link

ali-42 commented Oct 16, 2024

this overrides seems to do the trick for me on catppuccin mocha. I basically just revert back to the previous values for predictives as showed here : https://github.com/catppuccin/zed/pull/20/files

"experimental.theme_overrides": {
    "predictive": "#7688ae",
    "predictive.border": "#b4befe",
    "syntax": {
      "predictive": {
        "color": "#7688ae"
      }
    }
  },

Maybe that is something you can do and see if it breaks anything on mac os (I can't test on mac)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed linux
Projects
None yet
Development

No branches or pull requests

3 participants