We should [not] use assert to control program flow?

[graeme-winter]

Discussion topic / vote - derived from investigation of dials/dials#2253

We should use assert to control program flow e.g.

def datablocks_from_imagesets(imagesets):
    """Load a list of datablocks from imagesets."""

    datablocks = []
    if not isinstance(imagesets, list):
        imagesets = [imagesets]
    for imageset in imagesets:
        try:
            datablocks[-1].append(imageset)
        except (IndexError, AssertionError):
            datablocks.append(DataBlock([imageset]))
    return datablocks

it is appropriate to use raising of AssertionError to indcate that we should have a new DataBlock not a continuation of an existing one. Vote 👍 if you agree or 👎 if you do not, or comment below.

[graeme-winter]

Commentary: some motivation behind the DXTBX_ASSERT etc. available at

https://web.archive.org/web/20050226022241/http://www.cuj.com/documents/s=8464/cujcexp0308alexandr/

[graeme-winter]

See your AssertionError and raise RuntimeError as 100% should not be used