Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fhirAuthorization.expires_in is required field #65

Open
yashaskram opened this issue Oct 18, 2018 · 3 comments
Open

fhirAuthorization.expires_in is required field #65

yashaskram opened this issue Oct 18, 2018 · 3 comments

Comments

@yashaskram
Copy link

When launching sandbox app through HSPC, fhirAuthorization populates fine but missing expires_in field.

"fhirAuthorization": {
    "access_token": "ey..",
    "token_type": "Bearer",
    "scope": "patient/*.* user/*.* launch openid profile online_access",
    "subject": "48163c5e-88b5-4cb3-92d3-23b800caa927"
  },

The sandbox code sets the expires_in based on the expires_in smart launch token response but looks like HSPC is not sending expires_in value when launching sandbox as SOF app. Not sure if this is the right place to post this given this is related to HSPC sandbox. But also wondering if the sandbox code should catch this

@kpshek
Copy link
Contributor

kpshek commented Oct 18, 2018

Thanks for logging this @yashaskram. I've logged https://healthservices.atlassian.net/browse/SNDBX-875 to the HSPC group to fix this on their end.

I agree it would be good for us to validate this in the CDS Hooks Sandbox as well.

@kpshek
Copy link
Contributor

kpshek commented Oct 19, 2018

@yashaskram - Jacob over at HSPC was fantastic and deployed a change to their authorization server and now the expires_in field is being returned. I've confirmed this in the CDS Hooks Sandbox as well.

We can leave this issue open as I agree with you that it would be good for us to put in some validation to ensure that the expires_in field is always set.

@yashaskram
Copy link
Author

Great. thx @kpshek and Jacob

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants