Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Ensure flow for turning on / off the API + bluetooth is working. #95

Closed
timarney opened this issue Jun 21, 2020 · 3 comments · Fixed by #99, #100 or CovidShield/mobile#144
Closed

Ensure flow for turning on / off the API + bluetooth is working. #95

timarney opened this issue Jun 21, 2020 · 3 comments · Fixed by #99, #100 or CovidShield/mobile#144
Assignees
Labels
bluetooth high priority upstream pieces that should either be pulled from upstream or fixed here and pulled back

Comments

@timarney
Copy link
Member

We need to do a review of the flow and the different combinations of

  • blue tooth on/off & EN/ on/off

I have a PR here - #88

and

@ChrisDryden has a separate PR here #90 that

This PR is a demo of how using the "react-native-bluetooth-status" library can allow us to update the bluetooth status in the app for android and be able to check whether bluetooth is enabled for iOS and Android to render the Bluetooth enablement warning.


Via
@Stephen-PM

Ref: TestFlight 6.0

My bluetooth is off, but I am not getting the warning screen. Also, it should say StopCOVID is OFF.

@timarney
Copy link
Member Author

Per CovidShield/mobile#114

We need to coordinate with @dsamojlenko on Monday to get a build with entitlements pushed up.

@timarney
Copy link
Member Author

timarney commented Jun 21, 2020

CovidShield/mobile#137

Via CovidShield/mobile#125 (comment)

Hi @ChrisDryden ,

I was discussing with my team few days ago and we think it makes more sense for user to not care about bluetooth if using exposure notification (EN). That means:

The turn on bluetooth UI should be removed.
Android bridge for EN should also check bluetooth status and returns same payload as iOS.
When turn on EN, Android should turn on bluetooth at the same time.

@timarney timarney added upstream pieces that should either be pulled from upstream or fixed here and pulled back high priority labels Jun 21, 2020
@henrytao-me henrytao-me self-assigned this Jun 21, 2020
@timarney
Copy link
Member Author

We'll pull the upstream for Android when it's ready.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.