Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump dependencies #3

Open
majormoses opened this issue Jun 24, 2017 · 2 comments
Open

Bump dependencies #3

majormoses opened this issue Jun 24, 2017 · 2 comments

Comments

@majormoses
Copy link

Any chance on getting dependencies bumped I need to bump dependencies for elasticsearch https://github.com/sensu-plugins/sensu-plugins-elasticsearch/blob/1.3.1/sensu-plugins-elasticsearch.gemspec#L37 but this gem has conflicting dependencies. We need to update and release here in order to unblock us. I do not use aws ES service and while I could propose some changes I will need some help testing to ensure that we are not breaking anything.
majormoses added a commit to majormoses/aws-es-transport that referenced this issue Jun 24, 2017
@majormoses
closes cdunn#3 by bumping depedencies
daab174 
There are several motivations for this the most important being able to use newer than 1.x ES gem and limiting it to the 2 major gems (some thing might be broken and anyways I would consider this a breaking change).

gem deps bumped:
- `elasticsearch (['>= 2.0','<= 6.0'])`
- `faraday (~> 0.12)`
- `faraday_middleware (~> 0.11.0.1)

As part of this just to get everything to work in a modern version of ruby I had to do some other restructuring here are some of the misc changes:
- restructured gem lib structure (in order remove lots of require_relatives that were broken in ruby > 2)
- made versioning a bit easier to work with

Signed-off-by: Ben Abrams <[email protected]>
@majormoses
Copy link
Author

I have opened #4 hopefully to address this.

majormoses added a commit to majormoses/aws-es-transport that referenced this issue Jun 24, 2017
@majormoses
closes cdunn#3 by bumping depedencies
35436b4 
There are several motivations for this the most important being able to use newer than 1.x ES gem and limiting it to the 2 major gems (some thing might be broken and anyways I would consider this a breaking change).

gem deps bumped:
- `elasticsearch (['>= 2.0','<= 6.0'])`
- `faraday (~> 0.12)`
- `faraday_middleware (~> 0.11.0.1)`

As part of this just to get everything to work in a modern version of ruby I had to do some other restructuring here are some of the misc changes:
- restructured gem lib structure (in order remove lots of require_relatives that were broken in ruby > 2)
- made versioning a bit easier to work with

Signed-off-by: Ben Abrams <[email protected]>
majormoses added a commit to majormoses/aws-es-transport that referenced this issue Jun 24, 2017
@majormoses
closes cdunn#3 by bumping depedencies
990c5ec 
There are several motivations for this the most important being able to use newer than 1.x ES gem and limiting it to the 2 major gems (some thing might be broken and anyways I would consider this a breaking change).

gem deps bumped:
- `elasticsearch (['>= 2.0','<= 6.0'])`
- `faraday (~> 0.12)`
- `faraday_middleware (~> 0.11.0.1)`

As part of this just to get everything to work in a modern version of ruby I had to do some other restructuring here are some of the misc changes:
- restructured gem lib structure (in order remove lots of require_relatives that were broken in ruby > 2)
- made versioning a bit easier to work with

Signed-off-by: Ben Abrams <[email protected]>
@majormoses
Copy link
Author

sorry saw an issue so I closed it I have fixed this and opened #5 to address.

@majormoses majormoses mentioned this issue Mar 1, 2018
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@majormoses