From 1647aa73bddadd1c344f40ef51e03d542762f8ae Mon Sep 17 00:00:00 2001 From: Max Horn Date: Mon, 6 Feb 2023 12:22:18 +0100 Subject: [PATCH 1/4] Update CI --- .github/workflows/CI.yml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index cbb6103..3186ea5 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -25,10 +25,11 @@ jobs: matrix: gap-branch: - master + - stable-4.12 - stable-4.11 steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - uses: gap-actions/setup-gap@v2 with: GAP_PKGS_TO_BUILD: "io nq profiling" @@ -36,7 +37,7 @@ jobs: - uses: gap-actions/build-pkg@v1 - uses: gap-actions/run-pkg-tests@v2 - uses: gap-actions/process-coverage@v2 - - uses: codecov/codecov-action@v2 + - uses: codecov/codecov-action@v3 # The documentation job manual: @@ -44,7 +45,7 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - uses: gap-actions/setup-gap@v2 with: GAP_PKGS_TO_BUILD: "io nq profiling" @@ -52,7 +53,8 @@ jobs: with: use-latex: 'true' - name: 'Upload documentation' - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: manual path: ./doc/manual.pdf + if-no-files-found: error From 54499c32a1b2369da97158154ad1d0bc5340677a Mon Sep 17 00:00:00 2001 From: cdwensley Date: Mon, 8 Jan 2024 19:09:45 +0000 Subject: [PATCH 2/4] avoid trivial function wrappers --- lib/algebra.gi | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/algebra.gi b/lib/algebra.gi index 5cf73c4..e61f2b0 100644 --- a/lib/algebra.gi +++ b/lib/algebra.gi @@ -2,7 +2,7 @@ ## #W algebra.gi The XMODALG package Zekeriya Arvasi #W & Alper Odabas -#Y Copyright (C) 2014-2022, Zekeriya Arvasi & Alper Odabas, +#Y Copyright (C) 2014-2024, Zekeriya Arvasi & Alper Odabas, ## ############################ algebra operations ########################### @@ -134,7 +134,7 @@ InstallMethod( MultiplierAlgebraByGenerators, [ IsAlgebra, IsList ], 0, function ( A, L ) local I, ok, domA, M; - ok := ForAll( L, m -> IsAlgebraMultiplier( m ) ); + ok := ForAll( L, IsAlgebraMultiplier ); if not ok then Info( InfoXModAlg, 1, "L is not a list of multipliers" ); return fail; @@ -164,7 +164,7 @@ function( G, H ) if ( "IsGroupAlgebra" in KnownPropertiesOfObject(G) ) then H_G := UnderlyingGroup(G); L := MinimalGeneratingSet(H_G); - genG := List( L , g -> g^Embedding(H_G,G) ); + genG := List( L, g -> g^Embedding(H_G,G) ); else genG := GeneratorsOfAlgebra(G); fi; @@ -244,7 +244,7 @@ function( G, H ) if ( "IsGroupAlgebra" in KnownPropertiesOfObject(G) ) then H_G := UnderlyingGroup(G); L := MinimalGeneratingSet(H_G); - genG := List( L , g -> g^Embedding(H_G,G) ); + genG := List( L, g -> g^Embedding(H_G,G) ); else genG := GeneratorsOfAlgebra(G); fi; @@ -325,7 +325,7 @@ local A,B,a,b,h,f,i,sonuc,mler,j,k,eH,l,L,g,H_G,genG; eH := Elements(H); H_G := UnderlyingGroup(G); L := MinimalGeneratingSet(H_G); - genG := List( L , g -> g^Embedding(H_G,G) ); + genG := List( L, g -> g^Embedding(H_G,G) ); if ( Length(genG) = 0 ) then genG := GeneratorsOfAlgebra(G); fi; @@ -451,7 +451,7 @@ function( hom, U ) fi; gens:=GeneratorsOfAlgebra(U); - imgs:=List(gens,i->ImageElm(hom,i)); + imgs:=List( gens, i->ImageElm(hom,i) ); if HasImagesSource(hom) then imgp:=ImagesSource(hom); @@ -578,7 +578,7 @@ function( arg ) nargs := Length( arg ); # Algebra, Ideal, and Subalgebra - if ( ( nargs = 3 ) and ForAll( arg, a -> IsAlgebra(a) ) ) then + if ( ( nargs = 3 ) and ForAll( arg, IsAlgebra ) ) then return AlgebraActionByMultipliers( arg[1], arg[2], arg[3] ); # Multiplier Action elif ( ( nargs = 1 ) and IsAlgebra( arg[1] ) ) then From f6cdd9f245b14dbee3b101b6a245888f18e9e847 Mon Sep 17 00:00:00 2001 From: cdwensley Date: Tue, 23 Jan 2024 14:49:51 +0000 Subject: [PATCH 3/4] correct PR#70 - no test with stable-4.11 --- .github/workflows/CI.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 4079632..4650757 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -56,3 +56,4 @@ jobs: with: name: manual path: ./doc/manual.pdf + if-no-files-found: error From f3911be63898dd2550ab8a57e05b7122d927dcac Mon Sep 17 00:00:00 2001 From: Max Horn Date: Sat, 23 Mar 2024 22:35:19 +0100 Subject: [PATCH 4/4] CI: test with GAP 4.13; test with mininimal set of packages loaded --- .github/workflows/CI.yml | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 3186ea5..540dacd 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -25,17 +25,21 @@ jobs: matrix: gap-branch: - master + - stable-4.13 - stable-4.12 - stable-4.11 steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: gap-actions/setup-gap@v2 with: GAP_PKGS_TO_BUILD: "io nq profiling" GAPBRANCH: ${{ matrix.gap-branch }} - uses: gap-actions/build-pkg@v1 - uses: gap-actions/run-pkg-tests@v2 + - uses: gap-actions/run-pkg-tests@v2 + with: + only-needed: true - uses: gap-actions/process-coverage@v2 - uses: codecov/codecov-action@v3 @@ -45,7 +49,7 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: gap-actions/setup-gap@v2 with: GAP_PKGS_TO_BUILD: "io nq profiling" @@ -53,7 +57,7 @@ jobs: with: use-latex: 'true' - name: 'Upload documentation' - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: manual path: ./doc/manual.pdf