Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit date comparison between translated docs and original docs #3

Open
Jwaminju opened this issue Oct 1, 2024 · 0 comments
Open

Comments

@Jwaminju
Copy link

Jwaminju commented Oct 1, 2024

Hello @ceb10n,

I came across this repository while reading your article, and I'm interested in tracking outdated translation documentation.

I have a quick question regarding the commit date comparison logic in cli.py, specifically on line 93.

translation_is_outdated = translated_date > original_doc_date

Could you clarify why translation_is_outdated is set to True when translated_date is greater than original_doc_date? It seems like translation_is_outdated should be True when the original_doc_date is greater than the translated_date, ensuring the translation is older than the latest update to the original document.

Please correct me if I'm mistaken!

Thanks in advance for your help.
Since I'm not familiar with the proper way to contact you, I apologize for leaving my comment in the issue tab.

Best regards,
Minju

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant