You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Just letting you know that I noticed that your filterlists contains rules with invalid syntax for use with DNS blockers, such as rules containing $domain, etc.
This may cause issues for some DNS blockers, could you please provide a reformatted version of each list that is fully compliant with DNS blockers?
I use BadBlock+ with AdGuard Home, and I wish to avoid issues.
Metrokoto
changed the title
[OTHER] Invalid syntax for DNS blockers
[OTHER] Create DNS specific lists (Current ones contain invalid syntax for DNS blockers)
Oct 6, 2024
This is kind-of intentional. Reason being is that I'm trying to keep the maintenance cost as low as possible. This allows me to maintain the lists easier, meaning more list updates, etc. So of course I'd rather avoid maintaining two different ABP lists if only one is needed. After all, that is a benefit of ex. AdGuard Home being able to use ABP syntax.
I had considered creating separate lists before like you suggest, but my understanding is that the rules incompatible with AdGuard Home are just ignored, so it shouldn't cause any issues, at least AFAIK, so I didn't see a reason to.
Am I misunderstanding this? If this is in fact causing issues, then I will definitely separate the lists for browser vs. DNS level.
Am I misunderstanding this? If this is in fact causing issues, then I will definitely separate the lists for browser vs. DNS level.
Well, my AdGuard Home instance runs on bare metal with around 16 GB of RAM on an old Pentium Gold PC, but I would have thought on lower end hardware, the extra rules, as well as the fact it has to check if they are valid and ignore them if not and then store the states as such, it may cause performance dips in those devices.
I would suggest creating a DNS list as best practice but it's entirely up to you.
Additionally, I would assume AdGuard themselves has this logic for a reason:
! Bad: /banner.jpg (should be in general_url.txt)
I also assume they don't have anything outside of:
||example.com^
in the SDNS filter list for the exact same reason.
Well, my AdGuard Home instance runs on bare metal with around 16 GB of RAM on an old Pentium Gold PC, but I would have thought on lower end hardware, the extra rules, as well as the fact it has to check if they are valid and ignore them if not and then store the states as such, it may cause performance dips in those devices.
Fair point - I'll research this and see what I can do.
Hello, fellow filterlist dev here.
Just letting you know that I noticed that your filterlists contains rules with invalid syntax for use with DNS blockers, such as rules containing $domain, etc.
This may cause issues for some DNS blockers, could you please provide a reformatted version of each list that is fully compliant with DNS blockers?
I use BadBlock+ with AdGuard Home, and I wish to avoid issues.
Here is a link to a filterlist with valid syntax to follow as a guide;
https://adguardteam.github.io/AdGuardSDNSFilter/Filters/filter.txt
The text was updated successfully, but these errors were encountered: