Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up validation logic #4100

Open
cmwaters opened this issue Dec 9, 2024 · 0 comments
Open

Clean up validation logic #4100

cmwaters opened this issue Dec 9, 2024 · 0 comments

Comments

@cmwaters
Copy link
Contributor

cmwaters commented Dec 9, 2024

Summary

The way we validate the block and the transactions contained within that block is currently quite messy and spread out across the repo. This makes it difficult to follow what the actual validity rules are.

This arises predominantly because we have an introduced type BlobTxs which while a transaction, doesn't fit into the AnteHandler system. Thus BlobTx validation logic lives outside antehandlers. This means that logic such as restricting the total tx size also lives outside the antehandlers.

Proposal

There are various approaches:

  • modify the antehandler function signature: we could add an array of blobs to that field which would allow us to perform all transaction validation within antehandlers. However this would be an intrusive change to the existing cosmos sdk - we could circumvent this by just having a wrapper which would make it backwards compatible (a similar wrapper exists already for version gating the antehandlers)
  • create a blobTx antehandler: which is run just for blobTxs while the antehandler is run for non PFB transactions.
@cmwaters cmwaters added enhancement New feature or request and removed enhancement New feature or request labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant