You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After introducing versioned timeouts, it may be decided to remove the TimeoutCommit and TimeoutPropose fields from the configs. If this happens, then there is no need to validate them in the ConsensusConfig.ValidateBasic(). This issue serves as a reminder to proceed with this change, if that decision has been made.
The text was updated successfully, but these errors were encountered:
staheri14
changed the title
Considering removing timeout commit and timeout propose from configs
Considering removing timeout commit and timeout propose from configs after implementing versioned timeouts
Oct 11, 2024
staheri14
changed the title
Considering removing timeout commit and timeout propose from configs after implementing versioned timeouts
Considering removing validation of timeout commit and timeout propose ValidateBasic() after implementing versioned timeouts
Oct 11, 2024
staheri14
changed the title
Considering removing validation of timeout commit and timeout propose ValidateBasic() after implementing versioned timeouts
Considering removing validation of timeout commit and timeout propose from ValidateBasic() after implementing versioned timeouts
Oct 11, 2024
it may be decided to remove the TimeoutCommit and TimeoutPropose fields from the configs
I think we need to keep these in the celestia-app v3 binary because the config values should be used until the app version upgrades from 2 -> 3. So this issue can only be done in celestia-app v4.
Another idea: removing those two fields from the config may be considered breaking so proposal to keep them in config but document that they have no impact in >= v4 binary.
After introducing versioned timeouts, it may be decided to remove the TimeoutCommit and TimeoutPropose fields from the configs. If this happens, then there is no need to validate them in the
ConsensusConfig.ValidateBasic()
. This issue serves as a reminder to proceed with this change, if that decision has been made.The text was updated successfully, but these errors were encountered: