-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpc: decide on versioning #1345
Comments
We can add standard versioning to the gateway starting at v1 but for json rpc, I propose just versioning it via an endpoint that can be provided on the |
String is fine to me, although I would ask them why the made it as uint32 |
As another alternative, we could think about versioning the namespaces under which our modules are registered, but I think that's hairy. |
This is the correct approach IMO. Wouldn't say it's hairy but it adds some overhead for sure. |
Introduce a version string to the API Resolves #1345
We need to make a decision on how we want to version our RPC. In the future we could provide multiple versions at multiple endpoints. At the very least, it will be a failsafe for someone accidentally trying to use an old version of our api
We can then provide the first RPC at
/v1
for exampleAlso: return it as part of
node.Info
The text was updated successfully, but these errors were encountered: