Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resp is not returned from submitPFB in case an error returns #58

Open
omritoptix opened this issue Jun 6, 2023 · 0 comments · May be fixed by #59
Open

resp is not returned from submitPFB in case an error returns #58

omritoptix opened this issue Jun 6, 2023 · 0 comments · May be fixed by #59

Comments

@omritoptix
Copy link

resp should always be returned as it contains the tx hash which is crucial for following the tx block inclusion (even if an error occurred, e.g timeout).

reference: celestiaorg/celestia-node#2328
@walldiss walldiss linked a pull request Jun 6, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

client: submitpfb partial response support walldiss/go-cnc
1 participant
@omritoptix