Skip to content
This repository has been archived by the owner on Dec 7, 2018. It is now read-only.

Add SERVER_NAME and SERVER_PORT key to rack env. #18

Merged
merged 2 commits into from
Dec 19, 2014
Merged

Add SERVER_NAME and SERVER_PORT key to rack env. #18

merged 2 commits into from
Dec 19, 2014

Conversation

unakatsuo
Copy link
Contributor

Rack::Builder did not work because these variables were missed from env hash.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.42%) when pulling 50f294b on unakatsuo:fix-rack-builder into 5ea0a9f on celluloid:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.64%) when pulling 0107aa9 on unakatsuo:fix-rack-builder into 5ea0a9f on celluloid:master.

tarcieri added a commit that referenced this pull request Dec 19, 2014
@tarcieri
Merge pull request #18 from unakatsuo/fix-rack-builder
5c58e3c 
Add SERVER_NAME and SERVER_PORT key to rack env.
@tarcieri tarcieri merged commit 5c58e3c into celluloid:master Dec 19, 2014
@unakatsuo
Copy link
Contributor Author

#5, #8 and #15 relate to this PR and give alternative fix. they can be closed I think.

@benlangfeld
Copy link
Member

Any chance this could be included in a release, @tarcieri?

@tarcieri
Copy link
Member

Released in 0.2.2

@benlangfeld
Copy link
Member

Thanks @tarcieri

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@unakatsuo @coveralls @benlangfeld @tarcieri