Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forge test should be all green and exclude e2e tests that require a devchain #11106

Closed
arthurgousset opened this issue Jul 3, 2024 · 1 comment · Fixed by #11148
Closed

forge test should be all green and exclude e2e tests that require a devchain #11106

arthurgousset opened this issue Jul 3, 2024 · 1 comment · Fixed by #11148
Assignees
@arthurgousset

Comments

@arthurgousset
Copy link
Contributor

Expected Behavior

When forge test is run in the protocol/ package, all tests should pass.

Current Behaviorf

When forge test is run in the protocol/ package, it is currently expected that 3 tests are failing (the E2EDemo & 2 RegistryIntegrationTest). That's these tests require a devchain to be serving at localhost to pass.

This is confusing for new-joiners, because expecting tests to fail is not natural.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arthurgousset arthurgousset

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: forge test should be all green and exclude tests that require anvil celo-org/celo-monorepo
1 participant
@arthurgousset