Investigate other Value=0 cases for events in TxOpsFromLogs

[eelanagaraj]

There have been two edge cases identified thus far (GoldLocked and GoldWithdrawn). Take time to investigate whether it's possible to skip transfer creation for all Value=0 transactions in this function, or if there is a more robust solution here to prevent future issues with this.

Need to add for GoldWithdrawn, GoldLocked, GoldRelocked, GoldUnlocked ( + Election events as well)

Solution may be as simple as adding a check (Value==0, exclude those transfers), but double check that this does not break anything for the other events. (+ run full CLI checks if possible).

[aslawson]

Seems like remaining work here from DevX is to add this to checks to all the methods:GoldWithdrawn, GoldLocked, GoldRelocked, GoldUnlocked

Contract Changes are here: celo-org/celo-monorepo#7758

[barbaraliau]

Related to #7758

[AlexBHarley]

Some findings here. Logs are only matched with transfer if they are one of

• lockGold
• unlockGold
• slash.

This logic can be seen here.