diff --git a/src/oc_span.erl b/src/oc_span.erl index 106f279..f17e21f 100644 --- a/src/oc_span.erl +++ b/src/oc_span.erl @@ -41,7 +41,7 @@ %% Finish a span, setting the end_time and sending to the reporter. %% @end %%-------------------------------------------------------------------- --spec finish_span(opencensus:span_ctx(), maybe(opencensus:span())) -> true. +-spec finish_span(opencensus:span_ctx(), maybe(opencensus:span())) -> ok | {error, term()}. finish_span(#span_ctx{tracestate=Tracestate}, Span=#span{}) -> EndTime = wts:timestamp(), %% update tracestate to what the context has when finished @@ -49,7 +49,7 @@ finish_span(#span_ctx{tracestate=Tracestate}, Span=#span{}) -> tracestate=Tracestate}, oc_trace_reporter:store_span(Span1); finish_span(_, _) -> - true. + ok. %%-------------------------------------------------------------------- %% @doc diff --git a/test/oc_span_SUITE.erl b/test/oc_span_SUITE.erl index 01272ce..e6acac9 100644 --- a/test/oc_span_SUITE.erl +++ b/test/oc_span_SUITE.erl @@ -56,7 +56,7 @@ modifications(_Config) -> ?assertEqual({error, no_report_buffer}, oc_span:finish_span(#span_ctx{}, Span6)), {ok, _} = application:ensure_all_started(opencensus), - ?assertEqual(true, oc_span:finish_span(#span_ctx{}, Span6)), - ?assertEqual(true, oc_span:finish_span(#span_ctx{}, undefined)), + ?assertEqual(ok, oc_span:finish_span(#span_ctx{}, Span6)), + ?assertEqual(ok, oc_span:finish_span(#span_ctx{}, undefined)), application:stop(opencensus).