diff --git a/package-lock.json b/package-lock.json index b853fbee6a4..19bc76e9c70 100644 --- a/package-lock.json +++ b/package-lock.json @@ -40049,7 +40049,6 @@ "version": "6.89.0", "resolved": "https://registry.npmjs.org/terra-menu/-/terra-menu-6.89.0.tgz", "integrity": "sha512-iliRmresaILJoy/SW2j81PeCi8toL02SePXKNVdj56ej2Ye0yUfbufM7+l/ZXR+UBwBRk/BJIKe1ZQSPhawnmw==", - "dev": true, "dependencies": { "classnames": "^2.2.5", "keycode-js": "^3.1.0", @@ -40148,7 +40147,6 @@ "version": "6.78.0", "resolved": "https://registry.npmjs.org/terra-popup/-/terra-popup-6.78.0.tgz", "integrity": "sha512-QRqaolgisHKYT63fVUZz4hGddd5/jHvSSZg4FLjp4gN9L+cXAZ/DKsFGID9bsC4TvKIdnGszorcUK+c9Vvrd+Q==", - "dev": true, "dependencies": { "@cerner/terra-docs": "^1.0.0", "classnames": "^2.2.5", @@ -43631,7 +43629,7 @@ }, "packages/terra-core-docs": { "name": "@cerner/terra-core-docs", - "version": "1.68.0", + "version": "1.69.0", "license": "Apache-2.0", "dependencies": { "@cerner/terra-docs": "^1.11.0", @@ -43659,12 +43657,12 @@ "terra-form-fieldset": "^2.81.0", "terra-form-input": "^4.32.0", "terra-form-radio": "^4.53.0", - "terra-form-select": "^6.59.0", + "terra-form-select": "^6.60.0", "terra-form-textarea": "^5.33.0", "terra-grid": "^6.36.0", "terra-heading": "^4.55.0", "terra-html-table": "^1.18.0", - "terra-hyperlink": "^2.67.1", + "terra-hyperlink": "^2.68.0", "terra-i18n": "^4.42.0", "terra-icon": "^3.60.0", "terra-image": "^3.41.0", @@ -43876,7 +43874,7 @@ } }, "packages/terra-form-select": { - "version": "6.59.0", + "version": "6.60.0", "license": "Apache-2.0", "dependencies": { "classnames": "^2.2.5", @@ -43953,7 +43951,7 @@ } }, "packages/terra-hyperlink": { - "version": "2.67.1", + "version": "2.68.0", "license": "Apache-2.0", "dependencies": { "classnames": "^2.2.5", diff --git a/packages/terra-core-docs/src/terra-dev-site/test/hyperlink/StatesHyperlink.test.jsx b/packages/terra-core-docs/src/terra-dev-site/test/hyperlink/StatesHyperlink.test.jsx deleted file mode 100644 index 2aa7a4ee132..00000000000 --- a/packages/terra-core-docs/src/terra-dev-site/test/hyperlink/StatesHyperlink.test.jsx +++ /dev/null @@ -1,41 +0,0 @@ -import React from 'react'; -import classNames from 'classnames/bind'; -import Hyperlink from 'terra-hyperlink'; -import styles from 'terra-hyperlink/lib/HyperlinkTestCommon.module.scss'; - -const cx = classNames.bind(styles); - -const HyperlinkStates = () => ( - -); - -export default HyperlinkStates; diff --git a/packages/terra-core-docs/src/terra-dev-site/test/hyperlink/StatesHyperlinkButton.test.jsx b/packages/terra-core-docs/src/terra-dev-site/test/hyperlink/StatesHyperlinkButton.test.jsx deleted file mode 100644 index c2f3574650b..00000000000 --- a/packages/terra-core-docs/src/terra-dev-site/test/hyperlink/StatesHyperlinkButton.test.jsx +++ /dev/null @@ -1,37 +0,0 @@ -import React from 'react'; -import classNames from 'classnames/bind'; -import Hyperlink from 'terra-hyperlink'; -import styles from 'terra-hyperlink/lib/HyperlinkTestCommon.module.scss'; - -const cx = classNames.bind(styles); - -const HyperlinkButtonStates = () => ( - -); - -export default HyperlinkButtonStates; diff --git a/packages/terra-hyperlink/CHANGELOG.md b/packages/terra-hyperlink/CHANGELOG.md index ca238391ece..6a04719e096 100644 --- a/packages/terra-hyperlink/CHANGELOG.md +++ b/packages/terra-hyperlink/CHANGELOG.md @@ -2,6 +2,9 @@ ## Unreleased +* Fixed + * Fixed focus indicator for default and lowlight themes. + ## 2.68.0 - (March 27, 2024) * Changed diff --git a/packages/terra-hyperlink/src/Hyperlink.module.scss b/packages/terra-hyperlink/src/Hyperlink.module.scss index 54f35140448..0e69dea626b 100644 --- a/packages/terra-hyperlink/src/Hyperlink.module.scss +++ b/packages/terra-hyperlink/src/Hyperlink.module.scss @@ -39,8 +39,10 @@ &[data-focus-styles-enabled='true']:focus { background-color: var(--terra-hyperlink-focus-background-color, transparent); border-radius: var(--terra-hyperlink-focus-border-radius, 0.2142rem); - box-shadow: var(--terra-hyperlink-focus-box-shadow, 0 0 0 1px #4cb2e9, 0 0 0 3px rgba(76, 178, 233, 0.25)); + box-shadow: var(--terra-hyperlink-focus-box-shadow, none); color: var(--terra-hyperlink-focus-color, #001f67); + outline: var(--terra-hyperlink-focus-outline, 2px dashed #000); + outline-offset: var(--terra-hyperlink-focus-outline-offset, 1px); text-decoration: var(--terra-hyperlink-focus-text-decoration, underline); } diff --git a/packages/terra-hyperlink/src/HyperlinkTestCommon.module.scss b/packages/terra-hyperlink/src/HyperlinkTestCommon.module.scss index b0f1a250970..b4b011b87fe 100644 --- a/packages/terra-hyperlink/src/HyperlinkTestCommon.module.scss +++ b/packages/terra-hyperlink/src/HyperlinkTestCommon.module.scss @@ -6,26 +6,4 @@ .hyperlink-states { padding: 0 10px; } - - .is-visited { - color: var(--terra-hyperlink-visited-color, #006fc3); - } - - .is-hovered { - background-color: var(--terra-hyperlink-hover-background-color); - color: var(--terra-hyperlink-hover-color, #001f67); - text-decoration: var(--terra-hyperlink-hover-text-decoration, underline); - } - - .is-focused { - background-color: var(--terra-hyperlink-focus-background-color, transparent); - border-radius: var(--terra-hyperlink-focus-border-radius, 0.2142rem); - box-shadow: var(--terra-hyperlink-focus-box-shadow, 0 0 0 1px #4cb2e9, 0 0 0 3px rgba(76, 178, 233, 0.25)); - color: var(--terra-hyperlink-focus-color, #001f67); - text-decoration: var(--terra-hyperlink-focus-text-decoration, underline); - } - - .is-active { - color: var(--terra-hyperlink-active-color, #001f67); - } } diff --git a/packages/terra-hyperlink/src/clinical-lowlight-theme/Hyperlink.module.scss b/packages/terra-hyperlink/src/clinical-lowlight-theme/Hyperlink.module.scss index d023bdc0a32..fff7dc76493 100644 --- a/packages/terra-hyperlink/src/clinical-lowlight-theme/Hyperlink.module.scss +++ b/packages/terra-hyperlink/src/clinical-lowlight-theme/Hyperlink.module.scss @@ -9,7 +9,7 @@ --terra-hyperlink-hover-text-decoration: underline; --terra-hyperlink-focus-background-color: transparent; --terra-hyperlink-focus-border-radius: 0.2142rem; - --terra-hyperlink-focus-box-shadow: 0 0 1px 3px #004c76, 0 0 7px 4px #004c76; + --terra-hyperlink-focus-outline: 2px dashed #fff; --terra-hyperlink-focus-color: #007ee0; --terra-hyperlink-focus-text-decoration: underline; --terra-hyperlink-active-color: #007ee0; diff --git a/packages/terra-hyperlink/src/orion-fusion-theme/Hyperlink.module.scss b/packages/terra-hyperlink/src/orion-fusion-theme/Hyperlink.module.scss index eade5fa7c3a..26dbdcbbfc5 100644 --- a/packages/terra-hyperlink/src/orion-fusion-theme/Hyperlink.module.scss +++ b/packages/terra-hyperlink/src/orion-fusion-theme/Hyperlink.module.scss @@ -10,6 +10,7 @@ --terra-hyperlink-focus-background-color: transparent; --terra-hyperlink-focus-border-radius: 3px; --terra-hyperlink-focus-box-shadow: 0 0 0 1px #4cb2e9, 0 0 0 3px rgba(76, 178, 233, 0.25); + --terra-hyperlink-focus-outline: none; --terra-hyperlink-focus-color: #004c76; --terra-hyperlink-focus-text-decoration: underline; --terra-hyperlink-active-color: #0065a3; diff --git a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/clinical-lowlight-theme/en/chrome_tiny/hyperlink-spec/default.png b/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/clinical-lowlight-theme/en/chrome_tiny/hyperlink-spec/default.png index a5afbaa2466..294515f15a3 100644 Binary files a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/clinical-lowlight-theme/en/chrome_tiny/hyperlink-spec/default.png and b/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/clinical-lowlight-theme/en/chrome_tiny/hyperlink-spec/default.png differ diff --git a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/clinical-lowlight-theme/en/chrome_tiny/hyperlink-spec/disabled.png b/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/clinical-lowlight-theme/en/chrome_tiny/hyperlink-spec/disabled.png index 1e28d297d1b..18d22d549d1 100644 Binary files a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/clinical-lowlight-theme/en/chrome_tiny/hyperlink-spec/disabled.png and b/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/clinical-lowlight-theme/en/chrome_tiny/hyperlink-spec/disabled.png differ diff --git a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/clinical-lowlight-theme/en/chrome_tiny/hyperlink-spec/focused_hyperlink.png b/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/clinical-lowlight-theme/en/chrome_tiny/hyperlink-spec/focused_hyperlink.png index 7984ff23ef0..363696213ba 100644 Binary files a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/clinical-lowlight-theme/en/chrome_tiny/hyperlink-spec/focused_hyperlink.png and b/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/clinical-lowlight-theme/en/chrome_tiny/hyperlink-spec/focused_hyperlink.png differ diff --git a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/clinical-lowlight-theme/en/chrome_tiny/hyperlink-spec/focused_hyperlink_button.png b/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/clinical-lowlight-theme/en/chrome_tiny/hyperlink-spec/focused_hyperlink_button.png index c19cd95ed3e..15c8df163c0 100644 Binary files a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/clinical-lowlight-theme/en/chrome_tiny/hyperlink-spec/focused_hyperlink_button.png and b/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/clinical-lowlight-theme/en/chrome_tiny/hyperlink-spec/focused_hyperlink_button.png differ diff --git a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/clinical-lowlight-theme/en/chrome_tiny/hyperlink-spec/hyperlink-button.png b/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/clinical-lowlight-theme/en/chrome_tiny/hyperlink-spec/hyperlink-button.png deleted file mode 100644 index ea7085993cf..00000000000 Binary files a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/clinical-lowlight-theme/en/chrome_tiny/hyperlink-spec/hyperlink-button.png and /dev/null differ diff --git a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/clinical-lowlight-theme/en/chrome_tiny/hyperlink-spec/states.png b/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/clinical-lowlight-theme/en/chrome_tiny/hyperlink-spec/states.png deleted file mode 100644 index 81742cc99cc..00000000000 Binary files a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/clinical-lowlight-theme/en/chrome_tiny/hyperlink-spec/states.png and /dev/null differ diff --git a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/orion-fusion-theme/en/chrome_tiny/hyperlink-spec/audio.png b/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/orion-fusion-theme/en/chrome_tiny/hyperlink-spec/audio.png index 146ff46a891..2876ff4d64a 100644 Binary files a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/orion-fusion-theme/en/chrome_tiny/hyperlink-spec/audio.png and b/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/orion-fusion-theme/en/chrome_tiny/hyperlink-spec/audio.png differ diff --git a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/orion-fusion-theme/en/chrome_tiny/hyperlink-spec/disabled.png b/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/orion-fusion-theme/en/chrome_tiny/hyperlink-spec/disabled.png index 34e626d9020..8da9e15c8ae 100644 Binary files a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/orion-fusion-theme/en/chrome_tiny/hyperlink-spec/disabled.png and b/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/orion-fusion-theme/en/chrome_tiny/hyperlink-spec/disabled.png differ diff --git a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/orion-fusion-theme/en/chrome_tiny/hyperlink-spec/document.png b/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/orion-fusion-theme/en/chrome_tiny/hyperlink-spec/document.png index fe6225d3709..87f1360911d 100644 Binary files a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/orion-fusion-theme/en/chrome_tiny/hyperlink-spec/document.png and b/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/orion-fusion-theme/en/chrome_tiny/hyperlink-spec/document.png differ diff --git a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/orion-fusion-theme/en/chrome_tiny/hyperlink-spec/focused_hyperlink.png b/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/orion-fusion-theme/en/chrome_tiny/hyperlink-spec/focused_hyperlink.png index 43ef8c197f9..cf8fd1beead 100644 Binary files a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/orion-fusion-theme/en/chrome_tiny/hyperlink-spec/focused_hyperlink.png and b/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/orion-fusion-theme/en/chrome_tiny/hyperlink-spec/focused_hyperlink.png differ diff --git a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/orion-fusion-theme/en/chrome_tiny/hyperlink-spec/focused_hyperlink_button.png b/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/orion-fusion-theme/en/chrome_tiny/hyperlink-spec/focused_hyperlink_button.png index 4aa77b9bdd8..3ed9b41e4f0 100644 Binary files a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/orion-fusion-theme/en/chrome_tiny/hyperlink-spec/focused_hyperlink_button.png and b/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/orion-fusion-theme/en/chrome_tiny/hyperlink-spec/focused_hyperlink_button.png differ diff --git a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/orion-fusion-theme/en/chrome_tiny/hyperlink-spec/hyperlink-button.png b/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/orion-fusion-theme/en/chrome_tiny/hyperlink-spec/hyperlink-button.png deleted file mode 100644 index c6527530631..00000000000 Binary files a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/orion-fusion-theme/en/chrome_tiny/hyperlink-spec/hyperlink-button.png and /dev/null differ diff --git a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/orion-fusion-theme/en/chrome_tiny/hyperlink-spec/icon_non_wrapping.png b/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/orion-fusion-theme/en/chrome_tiny/hyperlink-spec/icon_non_wrapping.png index 30622098049..6e4c0715d75 100644 Binary files a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/orion-fusion-theme/en/chrome_tiny/hyperlink-spec/icon_non_wrapping.png and b/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/orion-fusion-theme/en/chrome_tiny/hyperlink-spec/icon_non_wrapping.png differ diff --git a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/orion-fusion-theme/en/chrome_tiny/hyperlink-spec/states.png b/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/orion-fusion-theme/en/chrome_tiny/hyperlink-spec/states.png deleted file mode 100644 index 9b8bfe390f5..00000000000 Binary files a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/orion-fusion-theme/en/chrome_tiny/hyperlink-spec/states.png and /dev/null differ diff --git a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/terra-default-theme/en/chrome_tiny/hyperlink-spec/disabled.png b/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/terra-default-theme/en/chrome_tiny/hyperlink-spec/disabled.png index 9d0813bfbe4..347dee7283d 100644 Binary files a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/terra-default-theme/en/chrome_tiny/hyperlink-spec/disabled.png and b/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/terra-default-theme/en/chrome_tiny/hyperlink-spec/disabled.png differ diff --git a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/terra-default-theme/en/chrome_tiny/hyperlink-spec/focused_hyperlink.png b/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/terra-default-theme/en/chrome_tiny/hyperlink-spec/focused_hyperlink.png index 38e9f7dbe52..4e024390340 100644 Binary files a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/terra-default-theme/en/chrome_tiny/hyperlink-spec/focused_hyperlink.png and b/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/terra-default-theme/en/chrome_tiny/hyperlink-spec/focused_hyperlink.png differ diff --git a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/terra-default-theme/en/chrome_tiny/hyperlink-spec/focused_hyperlink_button.png b/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/terra-default-theme/en/chrome_tiny/hyperlink-spec/focused_hyperlink_button.png index 13ba9de0aad..4240299bb23 100644 Binary files a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/terra-default-theme/en/chrome_tiny/hyperlink-spec/focused_hyperlink_button.png and b/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/terra-default-theme/en/chrome_tiny/hyperlink-spec/focused_hyperlink_button.png differ diff --git a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/terra-default-theme/en/chrome_tiny/hyperlink-spec/hyperlink-button.png b/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/terra-default-theme/en/chrome_tiny/hyperlink-spec/hyperlink-button.png deleted file mode 100644 index 65a731b4853..00000000000 Binary files a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/terra-default-theme/en/chrome_tiny/hyperlink-spec/hyperlink-button.png and /dev/null differ diff --git a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/terra-default-theme/en/chrome_tiny/hyperlink-spec/states.png b/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/terra-default-theme/en/chrome_tiny/hyperlink-spec/states.png deleted file mode 100644 index 47c857ad9f7..00000000000 Binary files a/packages/terra-hyperlink/tests/wdio/__snapshots__/reference/terra-default-theme/en/chrome_tiny/hyperlink-spec/states.png and /dev/null differ diff --git a/packages/terra-hyperlink/tests/wdio/hyperlink-spec.js b/packages/terra-hyperlink/tests/wdio/hyperlink-spec.js index 4ece32808b5..1879f38ba44 100644 --- a/packages/terra-hyperlink/tests/wdio/hyperlink-spec.js +++ b/packages/terra-hyperlink/tests/wdio/hyperlink-spec.js @@ -54,12 +54,6 @@ Terra.describeViewports('Hyperlink', ['tiny'], () => { Terra.validates.element('scaled'); }); - it('should display hyperlink states', () => { - browser.url('/raw/tests/cerner-terra-core-docs/hyperlink/states-hyperlink'); - - Terra.validates.element('states'); - }); - it('should display Hyperlink with hidden underline', () => { browser.url('/raw/tests/cerner-terra-core-docs/hyperlink/underline-hidden-hyperlink'); @@ -80,12 +74,6 @@ Terra.describeViewports('Hyperlink', ['tiny'], () => { Terra.validates.element('focused hyperlink button'); }); - it('should render Hyperlink Button states when onClick is provided', () => { - browser.url('/raw/tests/cerner-terra-core-docs/hyperlink/states-hyperlink-button'); - - Terra.validates.element('hyperlink-button'); - }); - it('should render Hyperlinks with ellipses when the context should overflow', () => { browser.url('/raw/tests/cerner-terra-core-docs/hyperlink/truncated-hyperlink'); Terra.validates.element('truncated');