From e2ec97e98600c2148f8785d085bb201ed974d9f8 Mon Sep 17 00:00:00 2001 From: Akshar Date: Thu, 13 Jul 2023 12:01:11 +0530 Subject: [PATCH] Review comments --- packages/terra-content-container/CHANGELOG.md | 2 +- packages/terra-content-container/src/ContentContainer.jsx | 4 ++-- packages/terra-core-docs/CHANGELOG.md | 6 ++++++ 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/packages/terra-content-container/CHANGELOG.md b/packages/terra-content-container/CHANGELOG.md index 3d0115687fe..e20b4a91aca 100644 --- a/packages/terra-content-container/CHANGELOG.md +++ b/packages/terra-content-container/CHANGELOG.md @@ -3,7 +3,7 @@ ## Unreleased * Changed - * Addressed the focus style on click issue when `setFocusOnContainer` is not set + * Updated focus style when `setFocusOnContainer` is not set. ## 3.39.0 - (June 28, 2023) diff --git a/packages/terra-content-container/src/ContentContainer.jsx b/packages/terra-content-container/src/ContentContainer.jsx index 8d55769901d..6e5f2f9e1fb 100644 --- a/packages/terra-content-container/src/ContentContainer.jsx +++ b/packages/terra-content-container/src/ContentContainer.jsx @@ -62,7 +62,7 @@ const ContentContainer = ({ ...customProps }) => { const theme = React.useContext(ThemeContext); - const lightbackground = 'light'; + const lightBackground = 'light'; const contentLayoutClassNames = cx([ `content-container-${fill ? 'fill' : 'static'}`, @@ -72,7 +72,7 @@ const ContentContainer = ({ // setting tab index to 0 if setFocusOnContainer is set const scrollAttrs = (setFocusOnContainer) ? { tabIndex: 0 } : ''; // border will only be visible when setFocusOnContainer is set for content-container - const background = setFocusOnContainer && (backgroundColor || lightbackground); + const background = setFocusOnContainer && (backgroundColor || lightBackground); const scrollClassNames = cx( 'normalizer', theme.className, diff --git a/packages/terra-core-docs/CHANGELOG.md b/packages/terra-core-docs/CHANGELOG.md index 6867afd75d6..0cb1816b57d 100644 --- a/packages/terra-core-docs/CHANGELOG.md +++ b/packages/terra-core-docs/CHANGELOG.md @@ -2,11 +2,17 @@ ## Unreleased +* Added + * Added a test case for click event when setFocusOnContainer is disabled + * Changed * Minor formatting update in `terra-alert` & `terra-form-fieldset`. ## 1.30.0 - (July 11, 2023) +* Added + * Added test example for controlled form native select component. + * Added * Added test example for controlled form native select component. * Added more realistic examples for terra-toggle-button.