Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All occurrences of ${1%%.*}.html in edit function should be ${1%.*}.html #144

Open
wiake opened this issue Oct 30, 2017 · 0 comments
Open

Comments

@wiake
Copy link

wiake commented Oct 30, 2017

If the filename fullpath has dots in it appears to me that ${1%%.*}.html will strip too early(?). For example: building a blog in local github directory named anything/yourname.github.io/ and trying to edit fileone.html in there. If I am correct, the result would be anything/yourname.html (so will get a "Can't edit post" error message), since matched on first dot. If just trying to strip whatever the file extension is, then seems to me should be ${1%.*}.html. Same throughout that edit() function (timestamps etc).

i.e. should be "shortest part of $Pattern that matches the back end of $var" if simply wanting to strip the filename extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant