From 0fb5c6e57968e8a5aea30879e742697af6d8b445 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 5 Oct 2022 11:38:31 -0500 Subject: [PATCH 01/12] Bump ruby from `7a82cbe` to `50aca44` (#4265) --- Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Dockerfile b/Dockerfile index e8e0fc391..3630aba21 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,4 +1,4 @@ -FROM ruby:3-slim-bullseye@sha256:7a82cbe60f2a9fe0ec6a5872d957f21b2faff23551df55b5c9511a7a5136a9b3 as base +FROM ruby:3-slim-bullseye@sha256:50aca44abd5fcb8da329d9f399c1e0c1d29616ac41016251af9affb078d08294 as base ENV DEBIAN_FRONTEND=noninteractive ENV TZ=US/Pacific From 37310be0bdd728d852361b9b1efd3d40b6a5c22a Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 6 Oct 2022 05:56:33 -0500 Subject: [PATCH 02/12] Bump ruby from `50aca44` to `2fd51de` (#4268) --- Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Dockerfile b/Dockerfile index 3630aba21..7cd7d71e8 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,4 +1,4 @@ -FROM ruby:3-slim-bullseye@sha256:50aca44abd5fcb8da329d9f399c1e0c1d29616ac41016251af9affb078d08294 as base +FROM ruby:3-slim-bullseye@sha256:2fd51ded2c105603ad42099bc60a057ec93667a8ebefab75b780ea1d57efa517 as base ENV DEBIAN_FRONTEND=noninteractive ENV TZ=US/Pacific From 2c32e13a878ab1612919b24661e5839c18869822 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 7 Oct 2022 21:45:50 +1000 Subject: [PATCH 03/12] Bump github/codeql-action from 2.1.26 to 2.1.27 (#4271) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.26 to 2.1.27.
Changelog

Sourced from github/codeql-action's changelog.

CodeQL Action Changelog

[UNRELEASED]

No user facing changes.

2.1.27 - 06 Oct 2022

2.1.26 - 29 Sep 2022

2.1.25 - 21 Sep 2022

2.1.24 - 16 Sep 2022

No user facing changes.

2.1.23 - 14 Sep 2022

2.1.22 - 01 Sep 2022

2.1.21 - 25 Aug 2022

2.1.20 - 22 Aug 2022

No user facing changes.

2.1.19 - 17 Aug 2022

... (truncated)

Commits

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=2.1.26&new-version=2.1.27)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) ---
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/codeql-analysis.yml | 6 +++--- .github/workflows/scorecards-analysis.yml | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml index 1c382e452..d12902a26 100644 --- a/.github/workflows/codeql-analysis.yml +++ b/.github/workflows/codeql-analysis.yml @@ -33,7 +33,7 @@ jobs: # Initializes the CodeQL tools for scanning. - name: Initialize CodeQL - uses: github/codeql-action/init@e0e5ded33cabb451ae0a9768fc7b0410bad9ad44 + uses: github/codeql-action/init@807578363a7869ca324a79039e6db9c843e0e100 with: languages: ${{ matrix.language }} # If you wish to specify custom queries, you can do so here or in a config file. @@ -44,7 +44,7 @@ jobs: # Autobuild attempts to build any compiled languages (C/C++, C#, or Java). # If this step fails, then you should remove it and run the build manually (see below) - name: Autobuild - uses: github/codeql-action/autobuild@e0e5ded33cabb451ae0a9768fc7b0410bad9ad44 + uses: github/codeql-action/autobuild@807578363a7869ca324a79039e6db9c843e0e100 # ℹ️ Command-line programs to run using the OS shell. # 📚 https://git.io/JvXDl @@ -58,4 +58,4 @@ jobs: # make release - name: Perform CodeQL Analysis - uses: github/codeql-action/analyze@e0e5ded33cabb451ae0a9768fc7b0410bad9ad44 + uses: github/codeql-action/analyze@807578363a7869ca324a79039e6db9c843e0e100 diff --git a/.github/workflows/scorecards-analysis.yml b/.github/workflows/scorecards-analysis.yml index 4d290f18c..2712d2a1f 100644 --- a/.github/workflows/scorecards-analysis.yml +++ b/.github/workflows/scorecards-analysis.yml @@ -49,6 +49,6 @@ jobs: # Upload the results to GitHub's code scanning dashboard. - name: "Upload to code-scanning" - uses: github/codeql-action/upload-sarif@e0e5ded33cabb451ae0a9768fc7b0410bad9ad44 + uses: github/codeql-action/upload-sarif@807578363a7869ca324a79039e6db9c843e0e100 with: sarif_file: results.sarif From 0dde5076b496bf225fe9b49e640020a210ed1f87 Mon Sep 17 00:00:00 2001 From: Parker Lougheed Date: Fri, 7 Oct 2022 14:48:12 -0500 Subject: [PATCH 04/12] Update firebase-tools from 11.0.1 to 11.14.1 (#4270) --- .github/workflows/build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 74b4c56ad..1b058bb63 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -64,7 +64,7 @@ jobs: - uses: actions/setup-node@969bd2663942d722d85b6a8626225850c2f7be4b with: node-version: ${{ env.NODE_VERSION }} - - run: npm install -g firebase-tools@11.0.1 + - run: npm install -g firebase-tools@11.14.0 - uses: dart-lang/setup-dart@6a218f2413a3e78e9087f638a238f6b40893203d with: sdk: stable @@ -91,7 +91,7 @@ jobs: - uses: actions/setup-node@969bd2663942d722d85b6a8626225850c2f7be4b with: node-version: ${{ env.NODE_VERSION }} - - run: npm install -g firebase-tools@11.0.1 + - run: npm install -g firebase-tools@11.14.1 - uses: dart-lang/setup-dart@6a218f2413a3e78e9087f638a238f6b40893203d with: sdk: stable From 5e3160d1e0e420f73488ce8f1654c98c3153cd8c Mon Sep 17 00:00:00 2001 From: Parker Lougheed Date: Sun, 9 Oct 2022 08:11:06 -0500 Subject: [PATCH 05/12] Remove specific version mention when highlighting Flutter includes Dart (#4273) --- src/_includes/get-sdk.md | 2 +- src/tools/jetbrains-plugin.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/_includes/get-sdk.md b/src/_includes/get-sdk.md index 8f5b75ac0..188b68a27 100644 --- a/src/_includes/get-sdk.md +++ b/src/_includes/get-sdk.md @@ -3,7 +3,7 @@ you need an SDK. You can either download the Dart SDK directly (as described below) or [download the Flutter SDK,][] -which (as of Flutter 1.21) includes the full Dart SDK. +which includes the full Dart SDK. [download the Flutter SDK,]: {{site.flutter-docs}}/get-started/install diff --git a/src/tools/jetbrains-plugin.md b/src/tools/jetbrains-plugin.md index d6bf06afe..f826ba9f2 100644 --- a/src/tools/jetbrains-plugin.md +++ b/src/tools/jetbrains-plugin.md @@ -51,7 +51,7 @@ Install a JetBrains IDE if you don't already have one. Choose one: If you don't already have the Dart SDK, install it. You can get it either by itself or by downloading the Flutter SDK, -which (as of Flutter 1.21) includes the full Dart SDK. +which includes the full Dart SDK. Choose one: From e188064ca0e8a377606141ee3f68a027532404d0 Mon Sep 17 00:00:00 2001 From: Parker Lougheed Date: Thu, 13 Oct 2022 12:11:07 -0500 Subject: [PATCH 06/12] Fix z-index incompatibilities causing footer and banner overlap on scroll (#4279) --- src/_sass/components/_banner.scss | 2 ++ src/_sass/components/_search.scss | 2 +- src/_sass/components/_toc.scss | 2 +- src/_sass/main.scss | 8 ++++---- 4 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/_sass/components/_banner.scss b/src/_sass/components/_banner.scss index e82deba51..105fd939b 100644 --- a/src/_sass/components/_banner.scss +++ b/src/_sass/components/_banner.scss @@ -1,7 +1,9 @@ .banner { + position: relative; background-color: #e7f8ff; padding: 12px 0; text-align: center; + z-index: 1000; } .banner__text { diff --git a/src/_sass/components/_search.scss b/src/_sass/components/_search.scss index 91a72fd6b..bf4af4eb5 100644 --- a/src/_sass/components/_search.scss +++ b/src/_sass/components/_search.scss @@ -89,7 +89,7 @@ input.gsc-search-button { right: 20px; font-size: 30px; cursor: pointer; - z-index: 999; + z-index: 5; &:hover { color: $gray; } diff --git a/src/_sass/components/_toc.scss b/src/_sass/components/_toc.scss index 48f1af79f..363e0d58d 100644 --- a/src/_sass/components/_toc.scss +++ b/src/_sass/components/_toc.scss @@ -153,7 +153,7 @@ overflow-x: hidden; overflow-y: auto; overflow-wrap: break-word; - z-index: 999; + z-index: 5; // override shared/_toc.scss &.site-toc { diff --git a/src/_sass/main.scss b/src/_sass/main.scss index 63720ae95..9dbf9e24f 100644 --- a/src/_sass/main.scss +++ b/src/_sass/main.scss @@ -99,7 +99,7 @@ i.fa-external-link-alt { #page-footer { position: relative; - z-index: 5; + z-index: 1000; background-color: $site-color-footer; padding: 32px; @@ -193,7 +193,7 @@ i.fa-external-link-alt { margin-left: 20px; padding-right: 10px; cursor: pointer; - z-index: 9999; + z-index: 100; i { font-size: 32px; @@ -842,7 +842,7 @@ body.obsolete { min-width: 300px; max-width: calc(100vw - 60px); background: #fff; - z-index: 9999; + z-index: 100; box-shadow: 0 0 4px rgba(0,0,0,.14),0 4px 8px rgba(0,0,0,.28); transform: translateX(-100%); transition: transform 0.4s ease-in-out; @@ -864,7 +864,7 @@ body.obsolete { top: 0; bottom: 0; left: 0; right: 0; height: 100%; - z-index: 999; + z-index: 5; background-color: rgba($gray-base,0.5); cursor: pointer; pointer-events: none; From f73070023318b6c3c3f14a7fe4f8fe5f077628b8 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 14 Oct 2022 10:02:31 -0500 Subject: [PATCH 07/12] Bump actions/setup-node from 3.5.0 to 3.5.1 (#4283) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.5.0 to 3.5.1.
Release notes

Sourced from actions/setup-node's releases.

Update @​actions/core and Print Node, Npm, Yarn versions

In scope of this release we updated actions/core to 1.10.0. Moreover, we added logic to print Nodejs, Npm, Yarn versions after installation.

Commits

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/setup-node&package-manager=github_actions&previous-version=3.5.0&new-version=3.5.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) ---
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 1b058bb63..d2d523926 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -61,7 +61,7 @@ jobs: submodules: recursive - run: make build - run: make write-prod-robots - - uses: actions/setup-node@969bd2663942d722d85b6a8626225850c2f7be4b + - uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516 with: node-version: ${{ env.NODE_VERSION }} - run: npm install -g firebase-tools@11.14.0 @@ -88,7 +88,7 @@ jobs: with: submodules: recursive - run: make build - - uses: actions/setup-node@969bd2663942d722d85b6a8626225850c2f7be4b + - uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516 with: node-version: ${{ env.NODE_VERSION }} - run: npm install -g firebase-tools@11.14.1 From 8c1ee81b285648cb030491c67130a09356995165 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 14 Oct 2022 10:03:10 -0500 Subject: [PATCH 08/12] Bump FirebaseExtended/action-hosting-deploy from ff6e7dde58a4f7f1db590927596bf683250c6cc8 to 0.7.0 (#4282) Bumps [FirebaseExtended/action-hosting-deploy](https://github.com/FirebaseExtended/action-hosting-deploy) from ff6e7dde58a4f7f1db590927596bf683250c6cc8 to 0.7.0. This release includes the previously tagged commit.
Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) ---
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index d2d523926..c74189d2b 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -69,7 +69,7 @@ jobs: with: sdk: stable - run: tool/check-links.sh - - uses: FirebaseExtended/action-hosting-deploy@ff6e7dde58a4f7f1db590927596bf683250c6cc8 + - uses: FirebaseExtended/action-hosting-deploy@4d0d0023f1d92b9b7d16dda64b3d7abd2c98974b with: repoToken: '${{ secrets.GITHUB_TOKEN }}' firebaseServiceAccount: '${{ secrets.FIREBASE_SERVICE_ACCOUNT_DART_DEV }}' @@ -100,7 +100,7 @@ jobs: if: ${{ github.event.pull_request.head.repo.full_name == github.repository && github.event.pull_request.user.login != 'dependabot[bot]' }} - uses: FirebaseExtended/action-hosting-deploy@ff6e7dde58a4f7f1db590927596bf683250c6cc8 + uses: FirebaseExtended/action-hosting-deploy@4d0d0023f1d92b9b7d16dda64b3d7abd2c98974b with: repoToken: '${{ secrets.GITHUB_TOKEN }}' firebaseServiceAccount: '${{ secrets.FIREBASE_SERVICE_ACCOUNT_DART_DEV }}' From ba7f598286d8559c8f5a94556f4b484b78aa1b19 Mon Sep 17 00:00:00 2001 From: Parker Lougheed Date: Fri, 14 Oct 2022 21:03:10 -0500 Subject: [PATCH 09/12] Fix broken code excerpts showing up on library tour (#4284) --- src/_guides/libraries/_dart-html-tour.md | 4 ++-- src/_guides/libraries/_dart-io-tour.md | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/_guides/libraries/_dart-html-tour.md b/src/_guides/libraries/_dart-html-tour.md index f54d71a38..3c2f7cfc9 100644 --- a/src/_guides/libraries/_dart-html-tour.md +++ b/src/_guides/libraries/_dart-html-tour.md @@ -335,7 +335,7 @@ The HttpRequest static method `getString()` is an easy way to get data from a web server. Use `await` with the `getString()` call to ensure that you have the data before continuing execution. -/void/g"?> + {% prettify dart tag=pre+code %} void main() async { String pageHtml = [!await HttpRequest.getString(url);!] @@ -359,7 +359,7 @@ If you need access to the HttpRequest, not just the text data it retrieves, you can use the `request()` static method instead of `getString()`. Here’s an example of reading XML data: -/void/g; /await.*;/[!$&!]/g"?> + ```dart void main() async { HttpRequest req = await HttpRequest.request( diff --git a/src/_guides/libraries/_dart-io-tour.md b/src/_guides/libraries/_dart-io-tour.md index 71fc12376..0876ccd95 100644 --- a/src/_guides/libraries/_dart-io-tour.md +++ b/src/_guides/libraries/_dart-io-tour.md @@ -206,7 +206,7 @@ This server listens on port 8888 and address 127.0.0.1 (localhost), responding to requests for the path `/dart`. For any other path, the response is status code 404 (page not found). -/void/g; /\b_//g"?> + ```dart void main() async { final requests = await HttpServer.bind('localhost', 8888); @@ -242,7 +242,7 @@ apps. When programming in the browser, use the [dart:html HttpRequest class.][HttpRequest] Here’s an example of using HttpClient: -/void/g"?> + ```dart void main() async { var url = Uri.parse('http://localhost:8888/dart'); From cf529c60ec781d297a432776971ef7df94203274 Mon Sep 17 00:00:00 2001 From: Nate Bosch Date: Fri, 14 Oct 2022 21:47:27 -0700 Subject: [PATCH 10/12] Mention super parameters with initializing formals (#4274) Fixes #4262 Dart 2.17.0 introduced a syntax for implicitly forwarding constructor arguments to the super constructor. The type is inferred in the same way as initializing formals, so expand the section to include mention of `super.` syntax, and an example. Co-authored-by: Parker Lougheed --- examples/misc/lib/effective_dart/design_bad.dart | 11 +++++++++++ examples/misc/lib/effective_dart/design_good.dart | 11 +++++++++++ src/_guides/language/effective-dart/design.md | 15 +++++++++++++-- 3 files changed, 35 insertions(+), 2 deletions(-) diff --git a/examples/misc/lib/effective_dart/design_bad.dart b/examples/misc/lib/effective_dart/design_bad.dart index c26e3ca28..a96335b2b 100644 --- a/examples/misc/lib/effective_dart/design_bad.dart +++ b/examples/misc/lib/effective_dart/design_bad.dart @@ -8,6 +8,13 @@ import 'package:examples_util/ellipsis.dart'; import 'design_good.dart'; +class Key {} + +class StatelessWidget { + final Key? key; + StatelessWidget({this.key}); +} + void miscDeclAnalyzedButNotTested() { (errors, monsters, subscription) { // #docregion code-like-prose @@ -161,6 +168,10 @@ class Point1 { double x, y; Point1(double this.x, double this.y); } + +class MyWidget extends StatelessWidget { + MyWidget({Key? super.key}); +} // #enddocregion dont-type-init-formals //---------------------------------------------------------------------------- diff --git a/examples/misc/lib/effective_dart/design_good.dart b/examples/misc/lib/effective_dart/design_good.dart index 44e9bbf78..a557a9af1 100644 --- a/examples/misc/lib/effective_dart/design_good.dart +++ b/examples/misc/lib/effective_dart/design_good.dart @@ -35,6 +35,13 @@ class Padding extends Widget { Padding({required double padding, required Widget child}); } +class Key {} + +class StatelessWidget { + final Key? key; + StatelessWidget({this.key}); +} + void miscDeclAnalyzedButNotTested() { (Iterable errors, Iterable monsters) { // #docregion code-like-prose @@ -349,6 +356,10 @@ class Point1 { double x, y; Point1(this.x, this.y); } + +class MyWidget extends StatelessWidget { + MyWidget({super.key}); +} // #enddocregion dont-type-init-formals //---------------------------------------------------------------------------- diff --git a/src/_guides/language/effective-dart/design.md b/src/_guides/language/effective-dart/design.md index 5942637eb..3527bc5b2 100644 --- a/src/_guides/language/effective-dart/design.md +++ b/src/_guides/language/effective-dart/design.md @@ -1351,8 +1351,11 @@ function's parameters. In those cases, you may need to annotate. {% include linter-rule-mention.md rule="type_init_formals" %} -If a constructor parameter is using `this.` to initialize a field, then the type -of the parameter is inferred to have the same type as the field. +If a constructor parameter is using `this.` to initialize a field, +or `super.` to forward a super parameter, +then the type of the parameter +is inferred to have the same type as +the field or super-constructor parameter respectively. {:.good} @@ -1361,6 +1364,10 @@ class Point { double x, y; Point(this.x, this.y); } + +class MyWidget extends StatelessWidget { + MyWidget({super.key}); +} {% endprettify %} {:.bad} @@ -1370,6 +1377,10 @@ class Point { double x, y; Point(double this.x, double this.y); } + +class MyWidget extends StatelessWidget { + MyWidget({Key? super.key}); +} {% endprettify %} From baf91b3596b163032f6e66d7b7077ea53cb60b6c Mon Sep 17 00:00:00 2001 From: Parker Lougheed Date: Sat, 15 Oct 2022 16:49:03 -0500 Subject: [PATCH 11/12] Allow manually opened sidenav to be in front (#4285) --- src/_sass/components/_sidebar.scss | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/_sass/components/_sidebar.scss b/src/_sass/components/_sidebar.scss index 13dd679c1..bfd4c891f 100644 --- a/src/_sass/components/_sidebar.scss +++ b/src/_sass/components/_sidebar.scss @@ -116,6 +116,10 @@ overflow-y: auto; z-index: 1; + .open_menu & { + z-index: 10000; + } + .site-sidebar { // override shared/_sidebar.scss padding: $top-content-padding 30px $content-padding; From 0564683ee525265183ffbcdbf6d41c87ab73c4da Mon Sep 17 00:00:00 2001 From: Luke Cheng <2258420+chenglu@users.noreply.github.com> Date: Tue, 18 Oct 2022 16:48:41 +0800 Subject: [PATCH 12/12] typo fixes. --- src/get-dart/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/get-dart/index.md b/src/get-dart/index.md index 75467bb63..0c04e39b1 100644 --- a/src/get-dart/index.md +++ b/src/get-dart/index.md @@ -198,7 +198,7 @@ by [downloading the SDK as a zip file][]. 你可以通过本页面 [上方安装部分](#install) 的介绍来获取稳定版渠道的 Dart， 或者通过 [任一个包管理器 (如 brew、choco、apt get)][a package manager][] 或者通过 Dart 的 [Docker 镜像][Dart Docker image] 来获取 -稳定版 (Stable)、测试板 (Beta)、开发版 (Dev) 渠道的 Dart SDK， +稳定版 (Stable)、测试版 (Beta)、开发版 (Dev) 渠道的 Dart SDK， 再或者，你也可以直接 [下载各个版本的 SDK 压缩包][downloading the SDK as a zip file]。 For more information, see the [Dart 2 page.][Dart 2]