Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

io_adapter close() method logic error? #1492

Closed
tobeen opened this issue Jun 1, 2022 · 1 comment · Fixed by cfug/diox#33
Closed

io_adapter close() method logic error? #1492

tobeen opened this issue Jun 1, 2022 · 1 comment · Fixed by cfug/diox#33

Comments

@tobeen
Copy link

tobeen commented Jun 1, 2022

dio 4.0.6
in class io_adapter.dart
@OverRide
void close({bool force = false}) {
_closed = _closed;
_defaultHttpClient?.close(force: force);
}

is that _closed = _closed error?
should be:
@OverRide
void close({bool force = false}) {
_closed = true;
_defaultHttpClient?.close(force: force);
}
??
please check.

@AlexV525
Copy link
Member

Hi @tobeen. We've made our hardfork repo public and published a new version of dio, named diox.
The new package contains the PR of the fix.
Please refer to https://pub.dev/packages/diox/versions/5.0.0-dev.1 to use the fork.
You can also see why we're working for a hardfork at cfug/diox#29 and #1607.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants