-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
native_dio_adapter does not support onReceiveProgress and onSendProgress #1835
Comments
Hey, native_dio_adapter is still experimental so some issues are to be expected. Are you open to contribute this feature? |
@ueman While |
Awesome, thank you for the upcoming PR. Yes, please create a separate issue for
I was afraid of that. I think in the future we should get rid of that conversion layer, but that was the easiest way to get it working quickly. Additionally, while it's still experimental it can change at anytime, so using http as a target also kept the maintenance work to a minimum. |
That won't help to fix |
Oh I didn't know that. Then there should be an issue on their repo about that problem. |
I think that is desired behavior for them. They don't have any use cases for request streams, as there is no way to set the request body as a stream in |
<!-- Write down your pull request descriptions. --> Part of #1835 ### New Pull Request Checklist - [x] I have read the [Documentation](https://pub.dev/documentation/dio/latest/) - [x] I have searched for a similar pull request in the [project](https://github.com/cfug/dio/pulls) and found none - [x] I have updated this branch with the latest `main` branch to avoid conflicts (via merge from master or rebase) - [x] I have added the required tests to prove the fix/feature I'm adding - [ ] I have updated the documentation (if necessary) - [ ] I have run the tests without failures - [x] I have updated the `CHANGELOG.md` in the corresponding package ### Additional context and info (if any) <!-- Provide more context and info about the PR. --> --------- Co-authored-by: Jonas Uekötter <[email protected]>
I made a future request for cupertino_http package and when this is merged StreamingRequest will be working as intended. This should unblock the implementation of onSendProgress. |
They don't seem to be blocking anymore. Would you take another look if it requires further implementations? @Vovcharaa |
@AlexV525 It definitely requires implementation of the condition when to use |
@AlexV525 |
That doesn't prevent implementing it in this |
I agree. |
I think this would be good at this moment. |
Package
native_dio_adapter
Version
0.1.0
Output of
flutter doctor -v
Dart Version
3.0.1
Steps to Reproduce
Provide
onReceiveProgress
and/oronSendProgress
callback to any request method.Expected Result
Callback is called the same way as without native adapter.
Actual Result
Callback is called only once after download is done.
The text was updated successfully, but these errors were encountered: