Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP2 Adapter doesn't work with gzip response #1883

Closed
vicenterusso opened this issue Jun 29, 2023 · 2 comments
Closed

HTTP2 Adapter doesn't work with gzip response #1883

vicenterusso opened this issue Jun 29, 2023 · 2 comments

Comments

@vicenterusso
Copy link

Package

http2_adapter

Version

2.3.0

Output of flutter doctor -v

[!] Flutter (Channel stable, 3.7.12, on Fedora Linux 36 (KDE Plasma) 5.18.13-200.fc36.x86_64, locale pt_BR.UTF-8)
    • Flutter version 3.7.12 on channel stable at /home/vicente/fvm/versions/3.7.12
    ! Warning: `dart` on your path resolves to /home/linuxbrew/.linuxbrew/Cellar/dart/2.17.6/libexec/bin/dart, which is not inside your current Flutter SDK checkout at /home/vicente/fvm/versions/3.7.12. Consider adding /home/vicente/fvm/versions/3.7.12/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 4d9e56e694 (2 months ago), 2023-04-17 21:47:46 -0400
    • Engine revision 1a65d409c7
    • Dart version 2.19.6
    • DevTools version 2.20.1
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /home/vicente/Android/Sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /opt/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✗] Linux toolchain - develop for Linux desktop
    ✗ clang++ is required for Linux development.
      It is likely available from your distribution (e.g.: apt install clang), or can be downloaded from https://releases.llvm.org/
    ✗ CMake is required for Linux development.
      It is likely available from your distribution (e.g.: apt install cmake), or can be downloaded from https://cmake.org/download/
    ✗ ninja is required for Linux development.
      It is likely available from your distribution (e.g.: apt install ninja-build), or can be downloaded from https://github.com/ninja-build/ninja/releases
    • pkg-config version 1.8.0
    ✗ GTK 3.0 development libraries are required for Linux development.
      They are likely available from your distribution (e.g.: apt install libgtk-3-dev)

[✓] Android Studio (version 2021.2)
    • Android Studio at /opt/android-studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] VS Code (version 1.79.2)
    • VS Code at /usr/share/code
    • Flutter extension version 3.66.0

[✓] Connected device (3 available)
    • sdk gphone64 x86 64 (mobile) • emulator-5554 • android-x64    • Android 12 (API 31) (emulator)
    • Linux (desktop)              • linux         • linux-x64      • Fedora Linux 36 (KDE Plasma) 5.18.13-200.fc36.x86_64
    • Chrome (web)                 • chrome        • web-javascript • Google Chrome 109.0.5414.74

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 2 categories.

Dart Version

2.19.6

Steps to Reproduce

Any response with compressed content will throw an error "Unexpected character"

Expected Result

Any response with compressed content should be uncompressed automatically

Actual Result

I have no specific logs, just a DioExceptionType.unknown

@vicenterusso vicenterusso added h: need triage This issue needs to be categorized s: bug Something isn't working labels Jun 29, 2023
@AlexV525
Copy link
Member

Could you identify if the http2 package works with GZIP responses? If yes, then it's our adapter's issue, otherwise, it's caused by that package.

@AlexV525 AlexV525 added h: need more info Further information is requested and removed h: need triage This issue needs to be categorized s: bug Something isn't working labels Jul 10, 2023
@vicenterusso
Copy link
Author

I believe that http2 doesnt support automatic gzip decompression.

dart-lang/http#1357

@AlexV525 AlexV525 added i: out of support and removed h: need more info Further information is requested labels Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants