Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design of avk::context() actually prevents building as shared library #166

Open
libreliu opened this issue May 25, 2023 · 1 comment
Open

Comments

@libreliu
Copy link

Hi,

Thanks for the library!

But the code inside auto_vk_toolkit.hpp will actually be troublesome if Auto-Vk-Toolkit is linked dynamically, since multiple context_vulkan instances will exists in different part of the code (one in so/dll, another in the main program because it's inlined).

// include/auto_vk_toolkit.hpp#L201
	inline auto& context()
	{
		static context_vulkan sContext;
		return sContext;
	}
@johannesugb
Copy link
Member

I agree that it would be cool to have the possibility to build as dynamic library.
Unfortunately, I am currently unable to work on a refactoring like this, but pull requests are always welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants