From 710d0c10d6e84eec205bf0d398c672b2692a5f4b Mon Sep 17 00:00:00 2001
From: Mohamed Elmoslemany <mohamed.elmoslemany@chain4travel.com>
Date: Wed, 14 Aug 2024 13:46:10 +0200
Subject: [PATCH] latest changes from activity-info branch

---
 .../activity/v1alpha/activity_types.proto     |  9 +++---
 proto/cmp/types/v1alpha/delivery.proto        | 28 +++++++++++++++++++
 proto/cmp/types/v1alpha/redemption.proto      | 16 +++++++++++
 3 files changed, 49 insertions(+), 4 deletions(-)
 create mode 100644 proto/cmp/types/v1alpha/delivery.proto
 create mode 100644 proto/cmp/types/v1alpha/redemption.proto

diff --git a/proto/cmp/services/activity/v1alpha/activity_types.proto b/proto/cmp/services/activity/v1alpha/activity_types.proto
index d033ae3..aa25bcd 100644
--- a/proto/cmp/services/activity/v1alpha/activity_types.proto
+++ b/proto/cmp/services/activity/v1alpha/activity_types.proto
@@ -14,6 +14,8 @@ import "cmp/types/v1alpha/datetime_range.proto";
 import "cmp/types/v1alpha/duration.proto";
 import "cmp/types/v1alpha/contact_info.proto";
 import "cmp/types/v1alpha/product_code.proto";
+import "cmp/types/v1alpha/delivery.proto";
+import "cmp/types/v1alpha/redemption.proto";
 import "cmp/services/activity/v1alpha/search_result_types.proto";
 
 message ActivityExtendedInfo {
@@ -121,14 +123,13 @@ message ActivityDetails {
   string availability_type = 19;
 
   // Delivery Formats; such as QR Code, NFT, Ticket, ... etc
-  repeated string delivery_formats = 20;
+  repeated cmp.types.v1alpha.DeliveryFormat delivery_formats = 20;
 
   // Delivery Methods; such as Email, SMS, Post, ... etc
-  repeated string delivery_methods = 21;
+  repeated cmp.types.v1alpha.DeliveryMethod delivery_methods = 21;
 
   // Redemption method
-  string redemption_method = 22;
-
+  repeated cmp.types.v1alpha.RedemptionMethod redemption_method = 22;
 }
 
 
diff --git a/proto/cmp/types/v1alpha/delivery.proto b/proto/cmp/types/v1alpha/delivery.proto
new file mode 100644
index 0000000..386a105
--- /dev/null
+++ b/proto/cmp/types/v1alpha/delivery.proto
@@ -0,0 +1,28 @@
+syntax = "proto3";
+
+package cmp.types.v1alpha;
+
+// Delivery Formats and Methods
+//
+// ![Diagram](https://storage.googleapis.com/docs-cmp-files/diagrams/proto/cmp/types/v1alpha/delivery.proto.dot.xs.svg)
+// [Open Message Diagram](https://storage.googleapis.com/docs-cmp-files/diagrams/proto/cmp/types/v1alpha/delivery.proto.dot.svg)
+
+enum DeliveryFormat {
+    DELIVERY_FORMAT_UNSPECIFIED = 0;
+    DELIVERY_FORMAT_OTHER = 1;
+    DELIVERY_FORMAT_NFT = 2;
+    DELIVERY_FORMAT_QRCODE = 3;
+    DELIVERY_FORMAT_BARCODE = 4;
+    DELIVERY_FORMAT_PDF = 5;
+}
+
+
+enum DeliveryMethod {
+    DELIVERY_METHOD_UNSPECIFIED = 0;
+    DELIVERY_METHOD_OTHER = 1;
+    DELIVERY_METHOD_API = 2;
+    DELIVERY_METHOD_EMAIL = 3;
+    DELIVERY_METHOD_SMS = 4;
+    DELIVERY_METHOD_WHATSAPP = 5; 
+    DELIVERY_METHOD_POST = 6;
+}
diff --git a/proto/cmp/types/v1alpha/redemption.proto b/proto/cmp/types/v1alpha/redemption.proto
new file mode 100644
index 0000000..4511dfe
--- /dev/null
+++ b/proto/cmp/types/v1alpha/redemption.proto
@@ -0,0 +1,16 @@
+syntax = "proto3";
+
+package cmp.types.v1alpha;
+
+// Redemption Methods
+//
+// ![Diagram](https://storage.googleapis.com/docs-cmp-files/diagrams/proto/cmp/types/v1alpha/redemption.proto.dot.xs.svg)
+// [Open Message Diagram](https://storage.googleapis.com/docs-cmp-files/diagrams/proto/cmp/types/v1alpha/redemption.proto.dot.svg)
+
+enum RedemptionMethod {
+    REDEMPTION_METHOD_UNSPECIFIED = 0;
+    REDEMPTION_METHOD_OTHER = 1;
+    REDEMPTION_METHOD_DIGITAL = 2;
+    REDEMPTION_METHOD_PRINT = 3;
+    REDEMPTION_METHOD_MANIFEST = 4;
+}