From 06010d61859b696377d8f91a158ca4c1ed6cd6fd Mon Sep 17 00:00:00 2001 From: Vjera Turk Date: Wed, 7 Aug 2024 17:10:23 +0200 Subject: [PATCH 1/7] LocalizedDescriptionSet renamed to LocalizedDescriptions and made repeated field of LocalizedDescriptionSet --- proto/cmp/types/v1alpha/seat_map.proto | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/proto/cmp/types/v1alpha/seat_map.proto b/proto/cmp/types/v1alpha/seat_map.proto index f47458d..cb28b2f 100644 --- a/proto/cmp/types/v1alpha/seat_map.proto +++ b/proto/cmp/types/v1alpha/seat_map.proto @@ -60,9 +60,9 @@ message Section { // used to represent seat location inside this image). cmp.types.v1alpha.Image image = 5; - // A set of localized descriptions for this section, useful for providing + // A list of localized descriptions for this section, useful for providing // information about features and amenities in multiple languages. - cmp.types.v1alpha.LocalizedDescriptionSet localized_description_set = 6; + repeated cmp.types.v1alpha.LocalizedDescriptionSet localized_descriptions = 6; // Nested sections within this section, allowing for a hierarchical representation // of the venue's layout. @@ -90,9 +90,9 @@ message SeatMap { // bitmap format. cmp.types.v1alpha.Image image = 3; - // A set of localized descriptions for the seat map. This can be used to describe + // A list of localized descriptions for the seat map. This can be used to describe // features and amenities of the seating arrangement in multiple languages. - cmp.types.v1alpha.LocalizedDescriptionSet localized_description_set = 4; + repeated cmp.types.v1alpha.LocalizedDescriptionSet localized_descriptions = 4; } // List of _only_ seat IDs to be used for seat selection or seat availability. From 4b8eaf03e6c448731440d9ffe061bb020d9e3e5c Mon Sep 17 00:00:00 2001 From: Vjera Turk Date: Wed, 7 Aug 2024 17:16:09 +0200 Subject: [PATCH 2/7] CountryEntryRequirementCategory - the Items is made a repeated field --- proto/cmp/services/info/v1alpha/entry_requirements.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proto/cmp/services/info/v1alpha/entry_requirements.proto b/proto/cmp/services/info/v1alpha/entry_requirements.proto index 158b5c1..98d910b 100644 --- a/proto/cmp/services/info/v1alpha/entry_requirements.proto +++ b/proto/cmp/services/info/v1alpha/entry_requirements.proto @@ -77,7 +77,7 @@ message CountryEntryRequirementCategory { repeated cmp.types.v1alpha.LocalizedString names = 2; // Items - CountryEntryRequirementItem items = 3; + repeated CountryEntryRequirementItem items = 3; // Sub categories repeated CountryEntryRequirementCategory sub_categories = 4; From bfdcef12539c5cc5a70b6f5420b3979625d04a7b Mon Sep 17 00:00:00 2001 From: Vjera Turk Date: Thu, 8 Aug 2024 10:19:49 +0200 Subject: [PATCH 3/7] Added in the SeatMapRequest a repeated language field --- proto/cmp/services/seat_map/v1alpha/seat_map.proto | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/proto/cmp/services/seat_map/v1alpha/seat_map.proto b/proto/cmp/services/seat_map/v1alpha/seat_map.proto index ab8901b..9f26b66 100644 --- a/proto/cmp/services/seat_map/v1alpha/seat_map.proto +++ b/proto/cmp/services/seat_map/v1alpha/seat_map.proto @@ -1,7 +1,7 @@ syntax = "proto3"; package cmp.services.seat_map.v1alpha; - +import "cmp/types/v1alpha/language.proto"; import "cmp/types/v1alpha/common.proto"; import "cmp/types/v1alpha/seat_map.proto"; @@ -19,6 +19,9 @@ message SeatMapRequest { // This is the map ID that is received in the search results and also from the // product info responses. string map_id = 2; + + // Languages + repeated cmp.types.v1alpha.Language languages = 3; } // Response for seat map request From 3765406e863862b70b66a94e83ab4bedeba4023b Mon Sep 17 00:00:00 2001 From: Vjera Turk Date: Fri, 9 Aug 2024 09:19:17 +0200 Subject: [PATCH 4/7] WIP: Follow LocalizedDescriptionSet --- proto/cmp/types/v1alpha/seat_map.proto | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/proto/cmp/types/v1alpha/seat_map.proto b/proto/cmp/types/v1alpha/seat_map.proto index cb28b2f..1d8a76d 100644 --- a/proto/cmp/types/v1alpha/seat_map.proto +++ b/proto/cmp/types/v1alpha/seat_map.proto @@ -5,7 +5,7 @@ package cmp.types.v1alpha; import "cmp/types/v1alpha/description.proto"; import "cmp/types/v1alpha/file.proto"; import "google/protobuf/wrappers.proto"; - +import "cmp/types/v1alpha/language.proto"; // Represents a basic seat with optional features and restrictions. Each seat has a // unique identifier, a location within the seat map, and can have various static // features and restrictions associated with it. @@ -141,6 +141,12 @@ message SeatMapInventory { repeated SectionInventory sections = 2; } +message LocalizedSeatAttributeSet { + + Language language = 1; + repeated SeatAttribute seat_attributes = 2; + +} /* Helper messages */ // Defines a static attribute for a seat, which can be used for specifying features From c1ccd1a26aad5cf04b101469a8f1f4412f4a1508 Mon Sep 17 00:00:00 2001 From: Vjera Turk Date: Fri, 9 Aug 2024 09:25:58 +0200 Subject: [PATCH 5/7] For section name we use the already existing LocalizedString type --- proto/cmp/types/v1alpha/seat_map.proto | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/proto/cmp/types/v1alpha/seat_map.proto b/proto/cmp/types/v1alpha/seat_map.proto index 1d8a76d..f8698fc 100644 --- a/proto/cmp/types/v1alpha/seat_map.proto +++ b/proto/cmp/types/v1alpha/seat_map.proto @@ -6,6 +6,7 @@ import "cmp/types/v1alpha/description.proto"; import "cmp/types/v1alpha/file.proto"; import "google/protobuf/wrappers.proto"; import "cmp/types/v1alpha/language.proto"; +import "cmp/types/v1alpha/localized.proto"; // Represents a basic seat with optional features and restrictions. Each seat has a // unique identifier, a location within the seat map, and can have various static // features and restrictions associated with it. @@ -40,8 +41,8 @@ message Section { // "Orchestra" or "A", "12". Must be unique for each section. string id = 1; - // Human readable name of the section - string name = 2; + // List of localized names Human readable names of the section + repeated cmp.types.v1alpha.LocalizedString names = 2; // Seats in this section. oneof seat_info { From 56b22fd39077abc9c416562f1524ccf3213396d5 Mon Sep 17 00:00:00 2001 From: Vjera Turk Date: Fri, 9 Aug 2024 09:32:27 +0200 Subject: [PATCH 6/7] Explain repeated Language field --- proto/cmp/services/seat_map/v1alpha/seat_map.proto | 2 +- proto/cmp/types/v1alpha/seat_map.proto | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/proto/cmp/services/seat_map/v1alpha/seat_map.proto b/proto/cmp/services/seat_map/v1alpha/seat_map.proto index 9f26b66..1678cc2 100644 --- a/proto/cmp/services/seat_map/v1alpha/seat_map.proto +++ b/proto/cmp/services/seat_map/v1alpha/seat_map.proto @@ -20,7 +20,7 @@ message SeatMapRequest { // product info responses. string map_id = 2; - // Languages + // Requested Languages repeated cmp.types.v1alpha.Language languages = 3; } diff --git a/proto/cmp/types/v1alpha/seat_map.proto b/proto/cmp/types/v1alpha/seat_map.proto index f8698fc..05f2cee 100644 --- a/proto/cmp/types/v1alpha/seat_map.proto +++ b/proto/cmp/types/v1alpha/seat_map.proto @@ -93,6 +93,7 @@ message SeatMap { // A list of localized descriptions for the seat map. This can be used to describe // features and amenities of the seating arrangement in multiple languages. + // The languages should match those requested in SeatMapRequest repeated cmp.types.v1alpha.LocalizedDescriptionSet localized_descriptions = 4; } From 42bf29741d850671ee440dd73993e240c5e7c7d0 Mon Sep 17 00:00:00 2001 From: Vjera Turk Date: Fri, 9 Aug 2024 13:35:07 +0200 Subject: [PATCH 7/7] Use LocalizedSeatAttributeSet instead of SeatAttribute in Seat --- proto/cmp/types/v1alpha/seat_map.proto | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/proto/cmp/types/v1alpha/seat_map.proto b/proto/cmp/types/v1alpha/seat_map.proto index 05f2cee..f170008 100644 --- a/proto/cmp/types/v1alpha/seat_map.proto +++ b/proto/cmp/types/v1alpha/seat_map.proto @@ -20,10 +20,10 @@ message Seat { SeatLocation location = 2; // Static features associated with the seat, such as type, amenities, etc. - repeated SeatAttribute features = 3; + repeated LocalizedSeatAttributeSet features = 3; // Restrictions associated with the seat, such as age limits or accessibility requirements. - repeated SeatAttribute restrictions = 4; + repeated LocalizedSeatAttributeSet restrictions = 4; } // List of seats