Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert unwraps to ? #287

Closed
Tracked by #337
ceyhunsen opened this issue Sep 9, 2024 · 2 comments
Closed
Tracked by #337

Convert unwraps to ? #287

ceyhunsen opened this issue Sep 9, 2024 · 2 comments
Assignees
@mmtftr
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ceyhunsen
Copy link
Member

Proposal Description

In executable code, unwrap is not OK. Convert them to ? and return BridgeError.

This doesn't include tests.
@ceyhunsen ceyhunsen added enhancement New feature or request good first issue Good for newcomers labels Sep 9, 2024
@ekrembal ekrembal mentioned this issue Oct 14, 2024
Closed
34 tasks
@mmtftr mmtftr self-assigned this Jan 30, 2025
@mmtftr
Copy link

mmtftr commented Jan 30, 2025

I'll also be adding the unwrap_used lint in clippy with the option allow_in_tests = true

@mmtftr mmtftr mentioned this issue Jan 30, 2025
Merged
@mmtftr
Copy link

mmtftr commented Jan 31, 2025

Closed by #492

@mmtftr mmtftr closed this as completed Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmtftr mmtftr

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mmtftr @ceyhunsen