Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create tags through releases #439

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

h3rmanj
Copy link

@h3rmanj h3rmanj commented Feb 24, 2025

Addresses changesets/changesets#1545

When createGithubReleases is true, the action doesn't push the tags created locally by the publish command.

Instead, it creates tags through the createRelease api and provides the target_commitish value.

Tested running this in one of my repos, and it worked by providing a token generated from a GitHub App. However, I guess this would be breaking in some way, as it won't push tags unless there is a release generated by the release notes.

I think I could make it non-breaking by adding an input that specifically enables this behavior. Unsure what I would name it, maybe createTagsThroughReleases. I'd love some feedback on how this should be implemented if this is desired functionality, before I continue working on this.

Copy link

changeset-bot bot commented Feb 24, 2025

⚠️ No Changeset found

Latest commit: 4485716

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant