Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create tags through releases #439

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: create tags through releases #439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/run.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ const createRelease = async (
await octokit.rest.repos.createRelease({
name: tagName,
tag_name: tagName,
target_commitish: github.context.sha,
body: changelogEntry.content,
prerelease: pkg.packageJson.version.includes("-"),
...github.context.repo,
Expand Down Expand Up @@ -130,7 +131,11 @@ export async function runPublish({
{ cwd }
);

await gitUtils.pushTags();
// if we are creating github releases, we want to create the tag through the release api
// this allows tag workflows to be triggered if a custom token is provided
if (!createGithubReleases) {
await gitUtils.pushTags();
}

let { packages, tool } = await getPackages(cwd);
let releasedPackages: Package[] = [];
Expand Down